-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve globe constraints and panning precision #12114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good with the adjusted constraints! I left a note regarding the tracking ellipsoid to investigate, as I think it was mistakenly disabled it when adding globe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix globe constraints and improve panning precision * fix flow * reintroduce tracking ellipsoid * fix panning through anti-meridian * fixup * fix query test * update query geometry globe test
Closes #12001.
maxBounds
(same behavior as with alternative projections). Incidentally this fixes not being able to pan to the poles on the lowest zoom levels.Try it out and let me know if the new behavior looks good, and after we settle on it, I'll update the expected query/unit tests to pass (hence the draft status). This PR also doesn't address the zooming behavior which may get weird in certain situations, rotating the globe excessively, but we can follow up on that in a different PR.
Launch Checklist
@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Improve panning precision on Globe View and relax constrains on lower zoom levels</changelog>