Revert #3841 to fix full-page rendering in Firefox, Safari #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Jan 17, 2017
spinF
added a commit
to spinF/osm-liberty
that referenced
this pull request
Jan 17, 2017
Currently mapbox-gl v0.30.0 and v0.31.0 won't display the map in Firefox if the canvas is larger than 2048px in width or height (common on screens with resolution of 2K or higher). The problem was introduced by mapbox/mapbox-gl-js#3841, in mapbox/mapbox-gl-js#3915 the issue with Firefox was discovered and in mapbox/mapbox-gl-js#3986 the fix was released. So until v0.32.0 is released (which will incorporate the fix), I suggest reverting back to v0.29.0, which works fine with Firefox on large screens.
1ec5
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #3841 until we figure out why the
MAX_RENDERBUFFER_SIZEcheck regresses support for Firefox, as reported in #3915./cc @lucaswoj @stepankuzmin @jfirebaugh @morganherlocker