Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore "MAX_RENDERBUFFER_SIZE" check as a warning rather than an error #4037

Merged
merged 2 commits into from
Jan 23, 2017
Merged

Restore "MAX_RENDERBUFFER_SIZE" check as a warning rather than an error #4037

merged 2 commits into from
Jan 23, 2017

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Jan 23, 2017 •
edited
Loading

History

fixes #2893

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

mollymerp
mollymerp approved these changes Jan 23, 2017
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐑

@lucaswoj lucaswoj merged commit 33b3fc9 into master Jan 23, 2017
@lucaswoj lucaswoj deleted the MAX_RENDERBUFFER_SIZE branch January 23, 2017 23:25
lucaswoj pushed a commit that referenced this pull request Feb 3, 2017
Revert "Restore "MAX_RENDERBUFFER_SIZE" check as a warning rather tha…
bdcf227 
…n an error (#4037)"

This reverts commit 33b3fc9.
mourner pushed a commit that referenced this pull request Feb 4, 2017
@lucaswoj @mourner
Revert "Restore "MAX_RENDERBUFFER_SIZE" check as a warning rather tha…
7b2b879 
…n an error (#4037)" (#4207)

This reverts commit 33b3fc9.
mapsam pushed a commit that referenced this pull request Feb 8, 2017
@lucaswoj @mapsam
Revert "Restore "MAX_RENDERBUFFER_SIZE" check as a warning rather tha…
3ea6d03 
…n an error (#4037)" (#4207)

This reverts commit 33b3fc9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue an error when map canvas is larger than allowed by gl.MAX_RENDERBUFFER_SIZE
2 participants
@lucaswoj @mollymerp