-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] adds feedback component #8507
Conversation
* publisher-production: [docs] fix SDK support for symbol-sort-key (#8501) v1.1.1 fix #8481, unbounded memory growth in IE (#8490) fix race condition between caching and aborting (#8472) swap map-tiles example to use https (#8482) set antialias to true for custom layers and extrusion examples (#8474) update examples to use mapbox-gl-geocoder v4.4.1 (#8451) manually strip urls for faster cache matching (#8434) (#8449)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Looks good, and events are being reported correctly!
👋 @mapbox/gl-js this is ready to go, but we wanted to be mindful of merging since this PR makes changes to |
@katydecorah can we wait until Monday to merge this? we're working on creating a new release and having some issues with merging |
@ryanhamley definitely! I'll check back in on Monday |
@ryanhamley are we clear to merge this today? |
Yep you're good to go @katydecorah thanks! |
* origin/publisher-production: update version to v1.2.0 (#8562) Fix usage of String.includes which is es6 but not transformed by buble (#8565) (#8573) [docs] fix missing location prop to feedback component (#8554) Fix typo [docs] update dr-ui (#8548) [docs] fix errors on IE11 caused by dr-ui dependencies (#8544) updates directions plugin version (#8536) add dds sdk support squash (#8529) [docs] adds feedback component (#8507)
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
This PR adds a feedback component to bottom of pages and sections. This component is currently on all docs.mapbox.com sites and it looks like this:
The component will appear at the end of:
Note: since the Style spec's subsections tend to be shorter than subsections on the API page, we decided to only place the component at the end of each Style spec section.
After the launch of this final site, look out for an internal post from the docs team where we'll share how teams can review ratings for given sites and pages. We'll also share how the docs team is triaging this feedback on a daily basis.
Ref https://github.com/mapbox/documentation/issues/209
Launch Checklist
How to test
yarn run start-docs