[docs] fix errors on IE11 caused by dr-ui dependencies #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2019 13:03
ryanhamley
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
I tested this on IE11 and it works now! Thanks for the fix @katydecorah
ahk
pushed a commit
that referenced
this pull request
Jul 26, 2019
* Update batfish.config.js * update dr-ui
mourner
added a commit
that referenced
this pull request
Jul 30, 2019
* origin/publisher-production: update version to v1.2.0 (#8562) Fix usage of String.includes which is es6 but not transformed by buble (#8565) (#8573) [docs] fix missing location prop to feedback component (#8554) Fix typo [docs] update dr-ui (#8548) [docs] fix errors on IE11 caused by dr-ui dependencies (#8544) updates directions plugin version (#8536) add dds sdk support squash (#8529) [docs] adds feedback component (#8507)
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* Update batfish.config.js * update dr-ui
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* Update batfish.config.js * update dr-ui
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* Update batfish.config.js * update dr-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier this week the docs team received a report from the GL JS team that they were unable to test the local site on IE11. In addition, IE11 would not load maps on IE11 and showed the webgl is unsupported note despite webgl being enabled.
The bug is directly related to dependencies of dr-ui's Search component which use es2015 features and were not properly polyfilled.
This PR treats the symptoms of this bug in two ways:
mimic-fnanddebounce-fnto batfish config'sbabelIncludeto polyfill those dependencies which caused the initial error.website now loading properly in IE11
Launch Checklist