This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Podspec / submodule updates for 5.6.0-beta.1, adapt to gl-native immutable GeoJSON sources #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbarbosa
requested review from
jmkiley and
fabian-guerra
and removed request for
a team
December 12, 2019 20:26
julianrex
reviewed
Dec 12, 2019
julianrex
reviewed
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update INSTALL.md at the same time - unless that's in another PR?
captainbarbosa
changed the title
Podspec updates for 5.6.0-beta.1
Podspec / submodule updates for 5.6.0-beta.1
Dec 12, 2019
This is on ⏸ until mapbox/mapbox-gl-native#16053 is resolved. |
Possible fix going on in #101 |
captainbarbosa
changed the title
Podspec / submodule updates for 5.6.0-beta.1
Podspec / submodule updates for 5.6.0-beta.1, adapt to gl-native immutable GeoJSON sources
Dec 13, 2019
julianrex
reviewed
Dec 13, 2019
fabian-guerra
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. LGTM just two minor comments.
Closing in favor of #103 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
vendor/mapbox-gl-native
submodule to point torelease-tequila
.Install.md
to account for a changed installation process now that MapboxMobileEvents.framework is included as a dependency.