This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Declare mbgl::style::GeoJSONOptions as immutable #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix crash in noted in mapbox/mapbox-gl-native#16053 by declaring
mbgl::style::GeoJSONOptionsas anImmutabletype.Per chat with @asheemmamoowala, Android has implemented this in their own platform JNI code so they don't run into this issue. To be consistent, we should do the same on iOS.
So far, all of the changes in this PR seem to resolve the errors from mapbox/mapbox-gl-native#16053, but I'm still running into an issue related to
lmbgl-vendor-icu- running iosapp in this PR results in the build failing withLibrary not found for -lmbgl-vendor-icu:I'm not aware of what this library is used for. @asheemmamoowala has mentioned that @pozdnyakov may be able to diagnose this further.
Note: This PR also has the mapbox-gl-native PR pointed at the
release-tequilabranch.cc @mapbox/ios