This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cherry pick global symbol querying to release-boba #11952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Symbol querying is now global instead of per-tile - Symbols that bleed over tile boundaries no longer missed in queries - Symbol results now sorted based on rendering order (ie overlapping symbols change their sort order when a bearing change causes their render order to change) - Placement::retainedQueryData now responsible for maintaining symbol querying data for buckets that may no longer be in the TilePyramid.
ChrisLoer
force-pushed
the
boba-global-symbol-query
branch
from
6fb92f2
to
5046faa
Compare
ansis
approved these changes
May 22, 2018
This was referenced May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick from master of #11742, which moves symbol-querying away from a "per-tile" approach. From the original PR:
"querying near tile boundaries" was mapbox/mapbox-gl-js#5475.
"symbol buckets that have been re-sorted " was mapbox/mapbox-gl-js#6184.
At the time of #11742, there weren't any known issues with that pathway -- we just knew it was brittle. It turns out that pathway caused #11780 and (I think) #11788, which should both be fixed by this PR.
This PR depends on changes to the GL JS test suite that haven't yet merged into the GL JSrelease-bobabranch (see mapbox/mapbox-gl-js#6699). Once those go in we'll need to fix the pin here./cc @julianrex @jfirebaugh @ansis @lilykaiser @emerciercontexeo @shinma