Cherry pick global symbol query and tests #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses hover flicker from issues #5887 and #5506. Also fixes issue #5475/#6298, so that symbols that bleed over tile boundaries don't get missed. Under the hood, there are some good simplifications: - No round-tripping of viewport query coordinates through tile space - No more need to merge duplicate results from the same symbol showing up in multiple tiles - All querying-related data can now be indexed with a bucket instance id and a feature index - `Placement` now manages lifetime of any data needed to query against its CollisionIndex - CollisionBoxArray no longer involved in querying at all
Matches topDownComparator of FeatureIndex. Previous behavior was string sorting, which could provide unexpected results with multi-digit feature indices. Update query tests to match new order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of the global symbol query behavior and associated tests to the
release-bobaGL JS branch so that we can port mapbox/mapbox-gl-native#11742 to the nativerelease-bobabranch.cc @anandthakker @ansis