Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix potential integer overflow in line_atlas #1484

Merged
merged 2 commits into from
May 12, 2015
Merged

Conversation

springmeyer
Copy link
Contributor

Spotted thanks to clang++ -fsanitize=undefined:

line_atlas.cpp:115: runtime error: value 249 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 249 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 250 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 251 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 252 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 253 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 254 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 255 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 255 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 255 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 255 is outside the range of representable values of type 'char'
line_atlas.cpp:115: runtime error: value 255 is outside the range of representable values of type 'char'

@springmeyer springmeyer added this to the iOS Beta 1 milestone May 8, 2015
@kkaefer
Copy link
Contributor

kkaefer commented May 11, 2015

We should replace this with std::unique_ptr managed code.

@kkaefer
Copy link
Contributor

kkaefer commented May 11, 2015

Please review.

@incanus
Copy link
Contributor

incanus commented May 11, 2015

Similar to #1485, does this have any practical implications for b1 or is it just housekeeping?

@jfirebaugh jfirebaugh removed this from the iOS Beta 1 milestone May 11, 2015
kkaefer added a commit that referenced this pull request May 12, 2015
Fix potential integer overflow in line_atlas
@kkaefer kkaefer merged commit fc74f8d into master May 12, 2015
@kkaefer kkaefer deleted the fix-line-atlas-overflow branch May 12, 2015 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants