Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fix integer overflow in line_buffer.cpp #1485

Closed
wants to merge 1 commit into from

Conversation

springmeyer
Copy link
Contributor

Spotted thanks to clang++ -fsanitize=undefined:

line_buffer.cpp:18: runtime error: value -146 is outside the range of representable values of type 'signed char'
line_buffer.cpp:18: runtime error: value -761 is outside the range of representable values of type 'signed char'
line_buffer.cpp:18: runtime error: value 761 is outside the range of representable values of type 'signed char'

@springmeyer springmeyer added this to the iOS Beta 1 milestone May 8, 2015
@kkaefer
Copy link
Contributor

kkaefer commented May 11, 2015

The underlying reason is that the line tessellation algorithm generates an extrude length that is way too long. We should find the reason that generates the overly long extrude vector and fix that instead.

@incanus
Copy link
Contributor

incanus commented May 11, 2015

What's the practical implication of this? Anything? Can we push to b2?

@kkaefer
Copy link
Contributor

kkaefer commented May 12, 2015

/cc @ansis

@jfirebaugh jfirebaugh closed this Sep 16, 2015
@jfirebaugh jfirebaugh deleted the fix-line-buffer-overflow branch September 16, 2015 19:06
@jfirebaugh
Copy link
Contributor

Thanks @springmeyer; closing here since the branch was stale and we need to address the underlying issue instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants