Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge both frameworks into a single podspec #140

Closed
wants to merge 1 commit into from
Closed

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Apr 13, 2017

MapboxCoreNavigation is now a subspec of MapboxNavigation.

Fixes #108.

/cc @frederoni @bsudekum

MapboxCoreNavigation is now a subspec of MapboxNavigation.
@1ec5 1ec5 added build Issues related to builds and dependency management. ⚠️ DO NOT MERGE PR should not be merged! labels Apr 13, 2017
@1ec5 1ec5 self-assigned this Apr 13, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 13, 2017

This isn’t working correctly yet. If you use pod 'MapboxNavigation', CocoaPods winds up creating a MapboxNavigation.framework target but not a MapboxCoreNavigation.framework target. As a result, any import MapboxCoreNavigation statement in MapboxNavigation causes a build failure:

/path/to/mapbox-navigation-ios/MapboxNavigation/MGLMapView.swift:4:8: No such module 'MapboxCoreNavigation'

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 13, 2017

If you use pod 'MapboxNavigation/MapboxCoreNavigation', CocoaPods creates a MapboxNavigation.framework target, which means you have to import MapboxNavigation rather than MapboxCoreNavigation.

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 13, 2017

We may have to create a custom modulemap for the outer MapboxNavigation pod and specify it in the podspec using the module_map directive. But I’m not sure whether the subspec will be able to override the outer pod’s module_map directive to include its own classes.

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 14, 2017

I don’t see a good way forward on this issue: using a subspec for Mapbox Core Navigation is tantamount to merging it and Mapbox Navigation into the same product, which we need to avoid.

@1ec5 1ec5 closed this Apr 14, 2017
@1ec5 1ec5 deleted the 1ec5-subspec-108 branch April 14, 2017 18:49
@1ec5 1ec5 mentioned this pull request Jun 14, 2017
wishtrip-dev pushed a commit to wishtrip-dev/mapbox-navigation-ios that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management. ⚠️ DO NOT MERGE PR should not be merged!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant