-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Mapbox Maps SDK for iOS v6.0.0 #2437
Conversation
73062f7
to
99fc8ea
Compare
This PR needs to be rebased onto release-v1.0-pre-registry. |
f58a0d6
to
c30feaa
Compare
@1ec5 , Just rebased on release-v1.0-pre-registry and updated maps dependency to 5.10.0-beta.1 |
README.md
Outdated
1. Create a Mapbox API token (from your account page on [mapbox.com](https://www.mapbox.com)) with the `DOWNLOADS:READ` scope. | ||
**PLEASE NOTE: This is not the same as your production Mapbox API token.** | ||
Once you have the token, create a `~/.netrc` which looks like this: | ||
``` | ||
machine api.mapbox.com | ||
login mapbox | ||
password <INSERT API TOKEN> | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the section about installing the latest stable release, v0.40.0. Can you move these three changes down to the section about installing the beta?
We’ll remove this section once we publish a final release of v1.0.0. In the meantime, by the time map SDK v5.10.0 goes out, we’ll have to publish a v0.40.1 that prevents CocoaPods and Carthage from automatically upgrading to v5.10.0: #2447.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn’t get sent with my last review for some reason. 🤷
README.md
Outdated
1. Create a Mapbox API token (from your account page on [mapbox.com](https://www.mapbox.com)) with the `DOWNLOADS:READ` scope. | ||
**PLEASE NOTE: This is not the same as your production Mapbox API token.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular, it’s a private token – let’s warn the developer not to publish it online and not to stick it in Info.plist.
ba150dd
to
cc329b5
Compare
README.md
Outdated
1. Run `carthage update --platform iOS` to build just the iOS dependencies. | ||
1. Follow the rest of [Carthage’s iOS integration instructions](https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos). Your application target’s Embedded Frameworks should include `MapboxNavigation.framework`, `MapboxCoreNavigation.framework`, `MapboxNavigationNative.framework`, and `MapboxAccounts.framework`. | ||
|
||
## Installing the latest stable version with the Maps SDK 5.10.0-beta version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s already a section about this below, called “Installing the latest prerelease”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. the latest version of the branch contains it after rebasing. updated.
This PR updates the Maps SDK to
5.10.0-beta.1v6.0.0 and fixes CI to reflect new SDK registry workflow.