Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mapbox Maps SDK for iOS v6.0.0 #2437

Merged
merged 19 commits into from
Jul 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ step-library:
- &restore-cache
restore_cache:
keys:
- nav-cache-v2-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }}
- nav-cache-v2-{{ .Environment.CIRCLE_JOB }} # used if checksum fails
- nav-cache-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }}
- nav-cache-v3-{{ .Environment.CIRCLE_JOB }} # used if checksum fails

- &save-cache
save_cache:
key: nav-cache-v2-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }}
key: nav-cache-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }}
paths:
- Carthage

Expand Down Expand Up @@ -49,6 +49,10 @@ step-library:
echo "machine dl.bintray.com" > ~/.netrc
echo "login $BINTRAY_LOGIN" >> ~/.netrc
echo "password $BINTRAY_API_KEY" >> ~/.netrc
echo >> ~/.netrc
echo "machine api.mapbox.com" >> ~/.netrc
echo "login mapbox" >> ~/.netrc
echo "password $SDK_REGISTRY_TOKEN" >> ~/.netrc

- &update-carthage-version
run:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

* Carthage v0.35 or above is now required for installing this SDK if you use Carthage. ([`81a36d0`](https://github.com/mapbox/mapbox-navigation-ios/commit/81a36d090e8a0602b7144ee7697b7857675b496f))
* For the time being, MapboxCoreNavigation.framework depends on a build of MapboxNavigationNative.framework that is only available to authorized beta testers. Please contact your Mapbox sales representative or [support team](https://support.mapbox.com/) to learn more about the beta testing program. ([#2412](https://github.com/mapbox/mapbox-navigation-ios/pull/2412))
* MapboxNavigation depends on Mapbox Maps SDK for iOS v6.0.0. Before CocoaPods or Carthage can download Mapbox.framework, you need to create a special-purpose access token. See [the updated installation instructions in the readme](./README.md#installing-the-latest-prerelease) for more details. ([#2437](https://github.com/mapbox/mapbox-navigation-ios/pull/2437))
* Xcode 11.4.1 or above is now required for building this SDK from source. ([#2417](https://github.com/mapbox/mapbox-navigation-ios/pull/2417))
* Enabled MAU billing by default, so that SDKs usage of Mapbox APIs is [billed](https://www.mapbox.com/pricing/) together based on [monthly active users](https://docs.mapbox.com/help/glossary/monthly-active-users/) rather than individually by HTTP request. If you prefer to still use request-based billing, set the `MBXNavigationBillingMethod` key in Info.plist to `request` ([#2405](https://github.com/mapbox/mapbox-navigation-ios/pull/2405).
* Added a Greek localization. ([#2385](https://github.com/mapbox/mapbox-navigation-ios/pull/2385))
Expand Down
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
binary "https://www.mapbox.com/ios-sdk/MapboxAccounts.json" ~> 2.3.0
binary "https://mapbox-gl-native-ios.s3.amazonaws.com/public/internal/Mapbox-iOS-SDK.json" == 5.9.1000
binary "https://api.mapbox.com/downloads/v2/carthage/mobile-maps/mapbox-ios-sdk-dynamic.json" ~> 6.0
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" ~> 14.1.5
github "mapbox/mapbox-directions-swift" ~> 0.32
github "mapbox/turf-swift" ~> 0.5
Expand Down
4 changes: 2 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
binary "https://mapbox-gl-native-ios.s3.amazonaws.com/public/internal/Mapbox-iOS-SDK.json" "5.9.1000"
binary "https://api.mapbox.com/downloads/v2/carthage/mobile-maps/mapbox-ios-sdk-dynamic.json" "6.0.0"
binary "https://www.mapbox.com/ios-sdk/MapboxAccounts.json" "2.3.0"
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" "14.1.5"
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" "14.1.6"
github "CedarBDD/Cedar" "v1.0"
github "Quick/Nimble" "v8.1.1"
github "Quick/Quick" "v2.2.1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,18 +233,18 @@
"${PODS_ROOT}/Target Support Files/Pods-PodInstall/Pods-PodInstall-frameworks.sh",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/Mapbox.framework",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/Mapbox.framework.dSYM",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/EF3F193B-8B19-3D7A-9C4D-CC7ACB8FD1B2.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/AF8AFA46-95A0-3C36-89B4-0A23D7D0A613.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/224E36C4-6533-3853-8416-A668FDC17C35.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/E1D60A9C-E180-3412-BFDB-809E8A1C178E.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/C4CEBB96-98D0-316A-AACC-B5CFBF29F45A.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/CDD5B540-1ABC-3204-861B-AA6C2862AEE7.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/40708912-75DD-33DC-8FC2-7318A1B6A119.bcsymbolmap",
"${PODS_ROOT}/Mapbox-iOS-SDK/dynamic/55B2508F-CAC7-3275-87EF-C25C383DB097.bcsymbolmap",
"${PODS_ROOT}/MapboxAccounts/MapboxAccounts.framework",
"${BUILT_PRODUCTS_DIR}/MapboxCoreNavigation/MapboxCoreNavigation.framework",
"${BUILT_PRODUCTS_DIR}/MapboxDirections/MapboxDirections.framework",
"${BUILT_PRODUCTS_DIR}/MapboxMobileEvents/MapboxMobileEvents.framework",
"${BUILT_PRODUCTS_DIR}/MapboxNavigation/MapboxNavigation.framework",
"${PODS_ROOT}/MapboxNavigationNative/MapboxNavigationNative.framework",
"${PODS_ROOT}/MapboxNavigationNative/MapboxNavigationNative.framework.dSYM",
"${PODS_ROOT}/MapboxNavigationNative/F0E2DE44-2BB9-3962-8BC5-FD435E5909A6.bcsymbolmap",
"${PODS_ROOT}/MapboxNavigationNative/3B99A79B-2E8B-34B5-ABAA-D85AB8D5565D.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/MapboxSpeech/MapboxSpeech.framework",
"${BUILT_PRODUCTS_DIR}/Polyline/Polyline.framework",
"${BUILT_PRODUCTS_DIR}/Solar/Solar.framework",
Expand All @@ -254,18 +254,18 @@
outputPaths = (
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Mapbox.framework",
"${DWARF_DSYM_FOLDER_PATH}/Mapbox.framework.dSYM",
"${BUILT_PRODUCTS_DIR}/EF3F193B-8B19-3D7A-9C4D-CC7ACB8FD1B2.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/AF8AFA46-95A0-3C36-89B4-0A23D7D0A613.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/224E36C4-6533-3853-8416-A668FDC17C35.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/E1D60A9C-E180-3412-BFDB-809E8A1C178E.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/C4CEBB96-98D0-316A-AACC-B5CFBF29F45A.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/CDD5B540-1ABC-3204-861B-AA6C2862AEE7.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/40708912-75DD-33DC-8FC2-7318A1B6A119.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/55B2508F-CAC7-3275-87EF-C25C383DB097.bcsymbolmap",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxAccounts.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxCoreNavigation.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxDirections.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxMobileEvents.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxNavigation.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxNavigationNative.framework",
"${DWARF_DSYM_FOLDER_PATH}/MapboxNavigationNative.framework.dSYM",
"${BUILT_PRODUCTS_DIR}/F0E2DE44-2BB9-3962-8BC5-FD435E5909A6.bcsymbolmap",
"${BUILT_PRODUCTS_DIR}/3B99A79B-2E8B-34B5-ABAA-D85AB8D5565D.bcsymbolmap",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/MapboxSpeech.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Polyline.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Solar.framework",
Expand Down
24 changes: 12 additions & 12 deletions MapboxCoreNavigationTests/CocoaPodsTest/PodInstall/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PODS:
- Mapbox-iOS-SDK (5.9.0):
- Mapbox-iOS-SDK (6.0.0):
- MapboxMobileEvents (= 0.10.2)
- MapboxAccounts (2.3.0)
- MapboxCoreNavigation (0.40.0):
- MapboxCoreNavigation (1.0.0-beta.1):
- MapboxAccounts (~> 2.3.0)
- MapboxDirections (~> 0.32.0)
- MapboxMobileEvents (~> 0.10.2)
Expand All @@ -12,13 +12,13 @@ PODS:
- Polyline (~> 4.2)
- Turf (~> 0.5)
- MapboxMobileEvents (0.10.2)
- MapboxNavigation (0.40.0):
- Mapbox-iOS-SDK (~> 5.6)
- MapboxCoreNavigation (= 0.40.0)
- MapboxNavigation (1.0.0-beta.1):
- Mapbox-iOS-SDK (~> 6.0)
- MapboxCoreNavigation (= 1.0.0-beta.1)
- MapboxMobileEvents (~> 0.10.2)
- MapboxSpeech (~> 0.3.0)
- Solar (~> 2.1)
- MapboxNavigationNative (14.1.5)
- MapboxNavigationNative (14.1.6)
- MapboxSpeech (0.3.0)
- Polyline (4.2.1)
- Solar (2.1.0)
Expand All @@ -29,7 +29,7 @@ DEPENDENCIES:
- MapboxNavigation (from `../../../`)

SPEC REPOS:
https://github.com/cocoapods/specs.git:
trunk:
- Mapbox-iOS-SDK
- MapboxAccounts
- MapboxDirections
Expand All @@ -47,18 +47,18 @@ EXTERNAL SOURCES:
:path: "../../../"

SPEC CHECKSUMS:
Mapbox-iOS-SDK: a5915700ec84bc1a7f8b3e746d474789e35b7956
Mapbox-iOS-SDK: 48ff7550bd459b8494da8ef4d660a668e9187ef0
MapboxAccounts: 84abfdde95d9dc483f604c1b0fe1861edf691ce7
MapboxCoreNavigation: 13143ea1e2723ffe0cefb790e7bfa20508b357fd
MapboxCoreNavigation: f6ee6f4093a5fd02619bd9d3fc35b1e8cefe61b2
MapboxDirections: 7f36b3e9ef6a53fc997c114a341ab4da721756bd
MapboxMobileEvents: 2bc0ca2eedb627b73cf403258dce2b2fa98074a6
MapboxNavigation: 42bae50b0381dce317c85884ba0de38fc68a4814
MapboxNavigationNative: a4bb15f37b174b3bd998bb06e745bad64d4bcefa
MapboxNavigation: e031095fa956e6a4af90e57577392709e3826da0
MapboxNavigationNative: 05d47617f3d18c5e45d9b549cb82dc39cdb67693
MapboxSpeech: 403415e932e084cf290b9d55c49ab7ea210b9595
Polyline: 0e9890790292741c8186201a536b6bb6a78d02dd
Solar: 2dc6e7cc39186cb0c8228fa08df76fb50c7d8f24
Turf: bdcfefe60df3ca8dc5f742681c178e47f8c5a567

PODFILE CHECKSUM: d4084fe664fbacd0cffd88ab45eaed1ad907ad1d

COCOAPODS: 1.8.4
COCOAPODS: 1.9.3
2 changes: 1 addition & 1 deletion MapboxNavigation-Documentation.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Pod::Spec.new do |s|
s.dependency "MapboxAccounts", "~> 2.3.0"
s.dependency "MapboxDirections", "~> 0.32.0"
s.dependency "MapboxGeocoder.swift", "~> 0.10.0"
s.dependency "Mapbox-iOS-SDK", "~> 5.6"
s.dependency "Mapbox-iOS-SDK", "~> 6.0"
s.dependency "MapboxMobileEvents", "~> 0.10.2"
s.dependency "MapboxNavigationNative", "= 9.0.4"
s.dependency "Solar", "~> 2.1"
Expand Down
2 changes: 1 addition & 1 deletion MapboxNavigation.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Pod::Spec.new do |s|
s.module_name = "MapboxNavigation"

s.dependency "MapboxCoreNavigation", "#{s.version.to_s}"
s.dependency "Mapbox-iOS-SDK", "~> 5.6"
s.dependency "Mapbox-iOS-SDK", "~> 6.0"
s.dependency "Solar", "~> 2.1"
s.dependency "MapboxSpeech", "~> 0.3.0"
s.dependency "MapboxMobileEvents", "~> 0.10.2"
Expand Down
20 changes: 17 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ Alternatively, to install Mapbox Navigation using [Carthage](https://github.com/
github "mapbox/mapbox-navigation-ios" ~> 0.40
```

1. Run `carthage update --platform iOS` to build just the iOS dependencies.

1. Follow the rest of [Carthage’s iOS integration instructions](https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos). Your application target’s Embedded Frameworks should include `MapboxNavigation.framework`, `MapboxCoreNavigation.framework`, `MapboxNavigationNative.framework`, and `MapboxAccounts.framework`.

## Installing the latest prerelease
Expand All @@ -60,6 +58,14 @@ Alternatively, to install Mapbox Navigation using [Carthage](https://github.com/

To install Mapbox Navigation using [CocoaPods](https://cocoapods.org/):

1. Go to your [Mapbox account dashboard](https://account.mapbox.com/) and create an access token that has the `DOWNLOADS:READ` scope. **PLEASE NOTE: This is not the same as your production Mapbox API token. Make sure to keep it private and do not insert it into any Info.plist file.** Create a file named `.netrc` in your home directory if it doesn’t already exist, then add the following lines to the end of the file:
```
machine api.mapbox.com
login mapbox
password PRIVATE_MAPBOX_API_TOKEN
```
where _PRIVATE_MAPBOX_API_TOKEN_ is your Mapbox API token with the `DOWNLOADS:READ` scope.

1. Create a [Bintray](https://bintray.com/mapbox) account, then [request to be added to the Mapbox Navigation SDK beta testing program](https://docs.google.com/forms/d/1mzknLZf5W9o8-KnQJ1GiYyG2grXVRqNxqHruWYTRVPc/viewform).

1. [Get a Bintray API key](https://bintray.com/profile/edit).
Expand All @@ -84,6 +90,14 @@ To install Mapbox Navigation using [CocoaPods](https://cocoapods.org/):

Alternatively, to install Mapbox Navigation using [Carthage](https://github.com/Carthage/Carthage/) v0.35 or above:

1. Go to your [Mapbox account dashboard](https://account.mapbox.com/) and create an access token that has the `DOWNLOADS:READ` scope. **PLEASE NOTE: This is not the same as your production Mapbox API token. Make sure to keep it private and do not insert it into any Info.plist file.** Create a file named `.netrc` in your home directory if it doesn’t already exist, then add the following lines to the end of the file:
```
machine api.mapbox.com
login mapbox
password PRIVATE_MAPBOX_API_TOKEN
```
where _PRIVATE_MAPBOX_API_TOKEN_ is your Mapbox API token with the `DOWNLOADS:READ` scope.

1. Create a [Bintray](https://bintray.com/mapbox) account, then [request to be added to the Mapbox Navigation SDK beta testing program](https://docs.google.com/forms/d/1mzknLZf5W9o8-KnQJ1GiYyG2grXVRqNxqHruWYTRVPc/viewform).

1. [Get a Bintray API key](https://bintray.com/profile/edit).
Expand All @@ -98,7 +112,7 @@ Alternatively, to install Mapbox Navigation using [Carthage](https://github.com/

1. _(Optional)_ Clear your Carthage caches:
```bash
rm -rf ~/Library/Caches/carthage/ ~/Library/Caches/org.carthage.CarthageKit/binaries/{MapboxAccounts,MapboxNavigationNative,Mapbox-iOS-SDK}
rm -rf ~/Library/Caches/carthage/ ~/Library/Caches/org.carthage.CarthageKit/binaries/{MapboxAccounts,MapboxNavigationNative,mapbox-ios-sdk-dynamic}
```

1. Create a [Cartfile](https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md#github-repositories) with the following dependency:
Expand Down