Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

[1.14.1] Remove mapbox-gl-instrumentile #59

Closed
wants to merge 2 commits into from
Closed

[1.14.1] Remove mapbox-gl-instrumentile #59

wants to merge 2 commits into from

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Jun 23, 2021

I think, because of maplibre/maplibre-gl-js#172 we need this change in the next release.

@wipfli
Copy link
Contributor

wipfli commented Jun 23, 2021

Thanks for highlighting this. As far as I remember instrumentile measures how fast tiles are loaded. We don't need this. What happens if you remove the code?

@astridx
Copy link
Contributor Author

astridx commented Jun 26, 2021 •
edited
Loading

If remove mapbox-gl-instrumentile, I see the tiles, but I get additional error messages like this:

track1

@astridx astridx mentioned this pull request Jun 26, 2021
Merged
@astridx astridx changed the title [1.14.1] Rename mapbox to maplibre in docs/components/example.js [1.14.1] Remove mapbox-gl-instrumentile Jun 26, 2021
@astridx
Copy link
Contributor Author

astridx commented Jul 29, 2021

Close in favor of
#75

@astridx astridx closed this Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astridx @wipfli