Rename mapbox to maplibre in typings file #172
Conversation
|
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
| @@ -1,4 +1,4 @@ | |||
| // Type definitions for MapLibre GL JS 1.14.0-rc.1 | |||
| // Type definitions for MapLibre GL JS 1.14.0 | |||
There was a problem hiding this comment.
Is it necessary to have the version in the comment? This is something we might often step over and forget to update.
There was a problem hiding this comment.
Maybe not, not sure, it might be redundant now that's it's inside this repo...
| export type ResponseCallback<T> = (error?: Error, data?: T, cacheControl?: string, expires?: string) => void; | ||
|
|
||
| export type Cancelable = { cancel: () => void }; | ||
|
|
There was a problem hiding this comment.
What is the context of these two?
There was a problem hiding this comment.
Missing types in general. I took the full file from #30 and forgot to remove these two... I can remove them if needed...
|
Thanks @HarelM for the clean-up. Looks good to me ✅ |
|
So, what's the next step in order to merge this in? (and hopefully release a version with this to npm... :-)) |
|
I guess just click "squash and merge". You have write access to this repo, right? |
|
Is there a way for me to publish an npm pakcage as well? Some sort of github action? Other CI I can trigger? |
|
You can go ahead and create a release candidate on NPM by pushing a tag of the form |
|
And of course let's first publish release candidates and let's wait with actual releases. |
|
Sure thing. I'll do it later tonight. I need to commit the pakckage.json file with the version change for rc as well, right? |
|
Yes please. NPM will only see the version in the tag, but the docs website will use the version in
|
Launch Checklist
This PR is to update the typings definition to reflect the changes in the maplibre rename of mapbox elements. See #27
include before/after visuals or gifs if this PR includes visual changeswrite tests for all new functionalitydocument any changes to public APIspost benchmark scoresmanually test the debug pageadd an entry inside this element for inclusion in themaplibre-gl-jschangelog:<changelog></changelog>