Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use MapLibre #3

Closed
nyurik opened this issue Dec 9, 2020 · 4 comments
Closed

Update code to use MapLibre #3

nyurik opened this issue Dec 9, 2020 · 4 comments
Labels

Comments

@nyurik
Copy link
Member

nyurik commented Dec 9, 2020

Update all code to use MapLibre. Fork any libraries that are no longer open source, or keep referencing MapBox's libs if they still are.

@nyurik nyurik added the forking label Dec 9, 2020
@snickell
Copy link
Contributor

As discussed with @nyurik , we should probably defer this for our second release, first release's priorities are "build is solid+reliable, easy to switch to by a string replace, remove trademarks from human visible bits, doesn't break, published to npm asap"

@HarelM
Copy link
Collaborator

HarelM commented Jun 30, 2021

What's the status of this bug?
I believe this was implemented, wasn't it? Are there more items in this issue that we would like to push forward?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

This issue was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this as completed Dec 6, 2021
mfedderly pushed a commit to mfedderly/maplibre-gl-js that referenced this issue Jan 23, 2023
HarelM pushed a commit that referenced this issue Feb 2, 2023
…erformance (#2097)

* Throttle the image request queue while the map is moving to improve performance

The image request queue can cause frame rate glitches while the map is moving. To mitigate this, allow the map renderer to throttle the amount of requests processed by the image request queue until the map stops moving again.

* Add AJAX unit test.

* Fix cancelRequest function

* lint fixes

* Fix typo in comment.

* Make amount of throttling be configurable.

* Rename MAX_PARALLEL_IMAGE_REQUESTS_WHILE_THROTTLED to MAX_PARALLEL_IMAGE_REQUESTS_PER_FRAME_WHILE_THROTTLED

* Add getter/setter maxParallelImageRequestsPerFrameWhileThrottled()

* Fix lint issue.

* Fix math error when computing maxImageRequests.

* Add changelog entry

* Move image request queue functions out of ajax.ts and into new image_request_queue.ts.

* Move image request queue code back into ajax.ts to minimize diffs.

* Reorganize image request queue code into a class (ImageRequestQueue).

* Add jsdoc comments

* Modify ImageRequestQueue class to call itself directly rather than via the pure function wrappers.

* Remove one instance of `theQueue` syntax that wasn't necessary.

* Fix unit test failure.

* Update changelog with PR 2097

* merge 2101

* PR updates (#3)

* Remove unused tile request cache (#2101)

* Remove unused tile request cache

* Remove the public method to clear the storage

* Get rid of tile request cache's usages

* merge 2101

* Combine `ResourceType` interface and const into a single enum (#2103)

* Combine ResourceType interface and const into a single enum

Move it from ajax.ts to request_manager.ts

* Re-run render tests

* Assign strting values to the enum

* Revert changes to tests

* Fix typo

* Don't use MapLibre prefix; use const enum

* Fix "npm run test-build" on Windows (#2106)

* wip

* fixed path

* rename var

* remove timeout

* add type and use namespace

* test passed

* refactored and cleaned

* min test

* all working

* restore min test

* clean up the cancel function

---------

Co-authored-by: Matthew Mamonov <[email protected]>

* lint

* update to 754099

* PR feedback

* doc

---------

Co-authored-by: Adam Szofran <[email protected]>
Co-authored-by: Matthew Mamonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants