fix: order of normalizeSpriteURL and transformRequest in load sprites #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarelM
reviewed
Mar 25, 2024
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
==========================================
+ Coverage 87.50% 87.79% +0.28%
==========================================
Files 265 265
Lines 37970 37974 +4
Branches 2409 2402 -7
==========================================
+ Hits 33227 33339 +112
+ Misses 3665 3553 -112
- Partials 1078 1082 +4 ☔ View full report in Codecov by Sentry. |
15 tasks
|
@Kai-W can you resolve conflict and prepare this PR to be merged? I want to move forward with the breaking changes of version 5. |
transformRequest is now called once with ResourceType.Sprite and not seperatly for SpiteJSON and SpriteImage. URL validation and appending of json/png is done afterwards
|
I rebased the branch, but i dont know why the windows rendert test 0 is failing. @HarelM can you look at it? |
HarelM
reviewed
Oct 22, 2024
HarelM
approved these changes
Oct 22, 2024
jcary741
added a commit
to jcary741/maplibre-gl-js
that referenced
this pull request
Nov 2, 2024
… sprites (maplibre#3898)" This reverts commit 54cf54e
5 tasks
HarelM
added a commit
that referenced
this pull request
Nov 7, 2024
* Revert "fix: order of normalizeSpriteURL and transformRequest in load sprites (#3898)" This reverts commit 54cf54e * Fix URL parsing in normalizeSpriteURL * add documentation --------- Co-authored-by: Harel M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of transformRequest and normalizeSpriteURL on loading Sprites.
(#3897)
Launch Checklist
CHANGELOG.mdunder the## mainsection.