Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed url validation form normalizeSpriteURL #3923

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

Kai-W
Copy link
Contributor

@Kai-W Kai-W commented Mar 31, 2024

Temporary Fix for normalizeSpriteURL not working with relative URLs
See Issue #3897
Permanent Fix with API Breaking Changes: #3898

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (bec0505) to head (9c1e1c0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3923      +/-   ##
==========================================
+ Coverage   86.65%   86.69%   +0.03%     
==========================================
  Files         242      242              
  Lines       32479    32456      -23     
  Branches     1979     1977       -2     
==========================================
- Hits        28146    28139       -7     
+ Misses       3391     3388       -3     
+ Partials      942      929      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@HarelM HarelM merged commit 3d0f0db into maplibre:main May 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants