Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested blockquotes #1464

Merged
merged 4 commits into from
May 3, 2019
Merged

Nested blockquotes #1464

merged 4 commits into from
May 3, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 9, 2019

Marked version: master

Markdown flavor: All

Description

Removes recursion for nested blockquotes

Fixes #1462 demo

TODO:

  • clean up code
  • add more tests

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech changed the title [WIP] Nested blockquotes Nested blockquotes Apr 12, 2019
@styfle
Copy link
Member

styfle commented Apr 18, 2019

@UziTech Are these todo's still relevant?

  • clean up code
  • add more tests

@UziTech
Copy link
Member Author

UziTech commented Apr 18, 2019

Sorry no, I forgot to check them.

@styfle styfle added category: blockquotes L0 - security A security vulnerability within the Marked library is discovered labels Apr 18, 2019
@UziTech UziTech closed this Apr 25, 2019
@UziTech UziTech deleted the nested-blockquotes branch April 25, 2019 05:11
@UziTech UziTech restored the nested-blockquotes branch May 3, 2019 19:54
@UziTech UziTech reopened this May 3, 2019
@UziTech
Copy link
Member Author

UziTech commented May 3, 2019

I'm not sure why I closed this before. This should be ready to merge.

/cc @styfle @joshbruce @davisjam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: blockquotes L0 - security A security vulnerability within the Marked library is discovered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marked(">".repeat(5000)) crashes with recursion error
3 participants