-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested blockquote error #1495
Conversation
I added more tests and fixed a few other bugs in #1464 |
I'm actually thinking we should just revert #1464 #1464 and this PR fixes recursion limit for fully nested blockquotes
but it doesn't solve recursion for partially nested blockquotes
I'm not sure that we should have a special case for fully nested blockquotes. markdown-it solves this problem by limiting the recursion to 100 nested blockquotes, and I'm not sure how commonmark.js gets around this. |
That sounds pretty reasonable to me. I can't think of many scenarios where you would need that many nested blockquotes besides an email thread. |
Marked version: master
Description
Error thrown when nesting blockquote
>a\n>>b
#1494Contributor
Committer
In most cases, this should be a different person than the contributor.