Fix: dont check for unverified devices in left members #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
changed the title
dbkr
approved these changes
Feb 12, 2019
src/models/room.js
Outdated
| return true; | ||
| const membership = this.currentState.members[userId].membership; | ||
| // check for negative values rather than positive to be | ||
| // extra careful to not report false positives here |
There was a problem hiding this comment.
This isn't specific to your change, but this isn't actually a question of being extra careful: this is (currently) a tristate where a device can be verified, unverified or blocked, so it depends what you want to do in the case where the room contains blocked devices. In this case the presence of blocked devices won't affect the return of Room. hasUnverifiedDevices() which I think is probably the correct behaviour?
There was a problem hiding this comment.
I meant being careful with checking the membership, but actually I should probably use getEncryptionTargetMembers instead.
|
@dbkr good for another look |
dbkr
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.