This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix historical section #2016
Merged
fix historical section #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also to unbreak it since now !emptyContent get hidden Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…om:matrix-org/matrix-react-sdk into t3chguy/hide_empty_sublist Signed-off-by: Michael Telatynski <[email protected]> # Conflicts: # src/i18n/strings/en_EN.json
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
give it an emptyContent so it doesn't just go blank and confuse users if they have no historical rooms, and also this fixes it being auto-hidden by the new hide-when-noEmptyContent||searchFilter logic
Fixes element-hq/element-web#6941
Partial Fix for element-hq/element-web#5810 (
Also add some help text)