Tests for RoomCreate #9997
Tests for RoomCreate #9997
Conversation
andybalaam
added
the
T-Task
andybalaam
force-pushed
the
andybalaam/tests-for-RoomCreate
branch
from
138c922
to
9c7c5a4
Compare
andybalaam
force-pushed
the
andybalaam/tests-for-RoomCreate
branch
from
9c7c5a4
to
dbb8bcc
Compare
andybalaam
force-pushed
the
andybalaam/tests-for-RoomCreate
branch
from
dbb8bcc
to
251a387
Compare
| const wrapper = getComponent(createEvent); | ||
| expect(wrapper.getByText("Click here to see older messages.")).toHaveAttribute( | ||
| "href", | ||
| "https://matrix.to/#/old_room_id/tombstone_event_id", | ||
| ); |
There was a problem hiding this comment.
A very minor point that adds very little here, but I think the 'right' way (think I picked this up from the creator of RTL, not the docs, in this post here: KCD) is to render the component then use screen for querying.
As I said, minimal gain here.
There was a problem hiding this comment.
Good suggestion, applied - thanks.
| it("Opens the old room on click", () => { | ||
| const wrapper = getComponent(createEvent); | ||
| const link = wrapper.getByText("Click here to see older messages."); | ||
| fireEvent.click(link); |
There was a problem hiding this comment.
What would you think to using userEvent here instead? I'd say a larger gain to doing that than the previous suggestion, as userEvent fires a few more events (mouseover, hover etc.) than purely the click action so is a better model of user interaction. It would be imported and then used as userEvent.click(link) so would read the same.
There was a problem hiding this comment.
Sounds good - I was not aware of this - thanks!
Prep for MSC3946
Part of element-hq/element-web#24323
This change is marked as an internal change (Task), so will not be included in the changelog.