This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Tests for RoomCreate #9997
Merged
andybalaam
merged 3 commits into
matrix-org:develop
from
andybalaam:andybalaam/tests-for-RoomCreate
Jan 27, 2023
Merged
Tests for RoomCreate #9997
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
Copyright 2023 The Matrix.org Foundation C.I.C. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import React from "react"; | ||
import { fireEvent, render, RenderResult } from "@testing-library/react"; | ||
import { mocked } from "jest-mock"; | ||
import { EventType, MatrixEvent } from "matrix-js-sdk/src/matrix"; | ||
|
||
import dis from "../../../../src/dispatcher/dispatcher"; | ||
import SettingsStore from "../../../../src/settings/SettingsStore"; | ||
import RoomCreate from "../../../../src/components/views/messages/RoomCreate"; | ||
import { stubClient } from "../../../test-utils/test-utils"; | ||
import { Action } from "../../../../src/dispatcher/actions"; | ||
|
||
jest.mock("../../../../src/dispatcher/dispatcher"); | ||
|
||
describe("<RoomCreate />", () => { | ||
const userId = "@alice:server.org"; | ||
const roomId = "!room:server.org"; | ||
const createEvent = new MatrixEvent({ | ||
type: EventType.RoomCreate, | ||
sender: userId, | ||
room_id: roomId, | ||
content: { | ||
predecessor: { room_id: "old_room_id", event_id: "tombstone_event_id" }, | ||
}, | ||
event_id: "$create", | ||
}); | ||
|
||
function getComponent(event: MatrixEvent): RenderResult { | ||
return render(<RoomCreate mxEvent={event} />); | ||
} | ||
|
||
beforeEach(() => { | ||
jest.clearAllMocks(); | ||
mocked(dis.dispatch).mockReset(); | ||
jest.spyOn(SettingsStore, "getValue").mockReturnValue(false); | ||
jest.spyOn(SettingsStore, "setValue").mockResolvedValue(undefined); | ||
stubClient(); | ||
}); | ||
|
||
afterAll(() => { | ||
jest.spyOn(SettingsStore, "getValue").mockRestore(); | ||
jest.spyOn(SettingsStore, "setValue").mockRestore(); | ||
}); | ||
|
||
it("Renders as expected", () => { | ||
const wrapper = getComponent(createEvent); | ||
expect(wrapper.asFragment()).toMatchSnapshot(); | ||
}); | ||
|
||
it("Links to the old version of the room", () => { | ||
const wrapper = getComponent(createEvent); | ||
expect(wrapper.getByText("Click here to see older messages.")).toHaveAttribute( | ||
"href", | ||
"https://matrix.to/#/old_room_id/tombstone_event_id", | ||
); | ||
}); | ||
|
||
it("Opens the old room on click", () => { | ||
const wrapper = getComponent(createEvent); | ||
const link = wrapper.getByText("Click here to see older messages."); | ||
fireEvent.click(link); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What would you think to using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good - I was not aware of this - thanks! |
||
expect(dis.dispatch).toHaveBeenCalledWith({ | ||
action: Action.ViewRoom, | ||
event_id: "tombstone_event_id", | ||
highlighted: true, | ||
room_id: "old_room_id", | ||
metricsTrigger: "Predecessor", | ||
metricsViaKeyboard: false, | ||
}); | ||
}); | ||
}); |
24 changes: 24 additions & 0 deletions
24
test/components/views/messages/__snapshots__/RoomCreate-test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`<RoomCreate /> Renders as expected 1`] = ` | ||
<DocumentFragment> | ||
<div | ||
class="mx_EventTileBubble mx_CreateEvent" | ||
> | ||
<div | ||
class="mx_EventTileBubble_title" | ||
> | ||
This room is a continuation of another conversation. | ||
</div> | ||
<div | ||
class="mx_EventTileBubble_subtitle" | ||
> | ||
<a | ||
href="https://matrix.to/#/old_room_id/tombstone_event_id" | ||
> | ||
Click here to see older messages. | ||
</a> | ||
</div> | ||
</div> | ||
</DocumentFragment> | ||
`; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very minor point that adds very little here, but I think the 'right' way (think I picked this up from the creator of RTL, not the docs, in this post here: KCD) is to render the component then use
screen
for querying.As I said, minimal gain here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, applied - thanks.