Replace shutdown_room API with delete_room #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I read the documentation correctly, the API we need to use is Also, I suspect that we need a |
Yoric
added a commit
that referenced
this pull request
Jul 28, 2021
…id> - Resolves #76, closes #96 As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.
|
The reason is, that the patch is older than the last changes at the API. |
That makes sense :) |
|
I close it in preference to #117 |
Yoric
added a commit
that referenced
this pull request
Aug 17, 2021
…id> - Resolves #76, closes #96 As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #76
I am was not sure how to do the local unit tests.
I hope it helps to fix the issue.
Signed-off-by: Dirk Klimpel [email protected]