Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

remove purge_room and shutdown_room #9052

Closed
1 task done
richvdh opened this issue Jan 8, 2021 · 4 comments · Fixed by #8830
Closed
1 task done

remove purge_room and shutdown_room #9052

richvdh opened this issue Jan 8, 2021 · 4 comments · Fixed by #8830
Labels
A-Admin-API T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases

Comments

@richvdh
Copy link
Member

richvdh commented Jan 8, 2021 •
edited by callahad
Loading

v1.25.0 deprecated /_synapse/admin/v1/purge_room and /_synapse/admin/v1/shutdown_room/<room_id> (see #8829). We should remove them at some point in the future.

Blockers:
@richvdh
Copy link
Member Author

richvdh commented Jan 8, 2021

(NB currently mjolnir is using shutdown_room: matrix-org/mjolnir#76)

@dklimpel
Copy link
Contributor

dklimpel commented Jan 8, 2021

See PR: #8830

@dklimpel dklimpel mentioned this issue Jan 8, 2021
Merged
4 tasks
@clokep clokep linked a pull request Jan 11, 2021 that will close this issue
Remove deprecated Shutdown Room and Purge Room Admin API #8830
Merged
4 tasks
@richvdh richvdh added the Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases label Jun 2, 2021
@richvdh
Copy link
Member Author

richvdh commented Jun 2, 2021

We should set a deadline for this, so that we can wrap up #8830.

@callahad
Copy link
Contributor

callahad commented Jun 3, 2021

We'd like to do this by August, will discuss with Mjolnir owners

@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jun 11, 2021
Yoric added a commit to matrix-org/mjolnir that referenced this issue Jul 28, 2021
@Yoric
Replace shutdown_room API with DELETE /_synapse/admin/v1/rooms/<room_…
b37309b 
…id> - Resolves #76, closes #96

As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.
@Yoric Yoric mentioned this issue Jul 28, 2021
Merged
Yoric added a commit to matrix-org/mjolnir that referenced this issue Aug 17, 2021
@Yoric
Replace shutdown_room API with DELETE /_synapse/admin/v1/rooms/<room_…
62b30b1 
…id> - Resolves #76, closes #96

As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Admin-API T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated Shutdown Room and Purge Room Admin API dklimpel/synapse_archive
5 participants
@callahad @clokep @richvdh @dklimpel @erikjohnston