Ported Buildkite checks to Github actions #210
Conversation
|
Alright I pulled down the upstream repository and merged with my fork and pushed again. Hopefully that's better! |
Looks good now! Thanks! |
There was a problem hiding this comment.
I'm assuming you wanted another review of this PR since you answered all my questions, but apologies if you were still working on this round! And if you were waiting for review, note that hitting the request review button is the best way to communicate that 🙂
That said, this is starting to really shape up! I'll popped some hopefully help notes below.
anoadragon453
changed the title
There was a problem hiding this comment.
Heads up that if you've resolved an issue as part of a pull request comment thread, resolving the thread once discussion has finished and the suggestion has been implemented (or rejected) helps shrink the total vertical space of the PR.
Anyways, this PR looks ready to go 🎉 Thank you for your work on it! 🙂
|
Oh, actually, as a very pedantic last step, can I get you to sign off on your changes just in a comment stating your ownership of this code change? Details for doing so are here: https://github.com/matrix-org/sygnal/blob/master/CONTRIBUTING.md#sign-off |
|
Cool! I updated the original PR comment to include a sign-off statement. Thanks for all your helpful feedback! |
Sygnal 0.9.3 (2021-04-22) ========================= Features -------- - Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212)) - WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213)) Bugfixes -------- - Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216)) - Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220)) Updates to the Docker image --------------------------- - Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208)) Improved Documentation ---------------------- - Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188)) - Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193)) - Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215)) Internal Changes ---------------- - Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193)) - Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194)) - Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207)) - Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219)) - Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214)) - Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217)) Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
I ported the first of the CI/CL checks pipeline to Github Actions. I just want to make sure this port was correct before I ported the rest of the checks. Let me know if it is and I will update my pull request with the rest of the checks completed. Thank you!
Signed-off-by: Hillery Shay [email protected]