WebPush support for urgency and coalescing #213
Conversation
bwindels
force-pushed
the
bwindels/webpush-urgency-and-coalescing
branch
from
887c58b
to
589e1dc
Compare
sygnal/webpushpushkin.py
Outdated
| Provide a response object that matches the API expected from pywebpush. | ||
| pywebpush expects a synchronous API, while we use an asynchronous API. |
There was a problem hiding this comment.
This still serves as something that looks like a response to pywebpush, while actually containing the information to perform the request ourselves once pywebpush finishes. I agree the naming is not ideal, but couldn't come up with something better. Ideas?
| request = webpush( | ||
| subscription_info=subscription_info, | ||
| data=data, | ||
| ttl=self.ttl, | ||
| vapid_private_key=self.vapid_private_key, | ||
| vapid_claims=vapid_claims, | ||
| requests_session=self.http_agent_wrapper, | ||
| requests_session=self.http_request_factory, | ||
| ) | ||
| response = await request.execute( | ||
| self.http_agent, low_priority, topic | ||
| ) |
There was a problem hiding this comment.
where does the deduplication actually take place, out of interest?
There was a problem hiding this comment.
We don't do this, it happens in the push gateway. If you have two messages with the same topic header, the second will replace the first (if the first hasn't been delivered yet).
There was a problem hiding this comment.
ah, so there is a separate "push gateway" after sygnal (which I tend to think of as a, y'know, push gateway)?
There was a problem hiding this comment.
I mean, webpush pipes notification to a push provider (or gateway, hard to name things correctly with so many parts to it) like FCM that will actually deliver it to the browser application, similarly to how the apns and gcm pushkins forward it to the push providers of those platforms. Every browser that supports web push needs to have a server like this that application servers can post push messages to. It's the browser-specific push provider that will drop the first message if it hasn't been deliver yet.
Co-authored-by: Richard van der Hoff <[email protected]>
…matrix-org/sygnal into bwindels/webpush-urgency-and-coalescing
This reverts commit 5ad1226.
sygnal/webpushpushkin.py
Outdated
| Provide a response object that matches the API expected from pywebpush. | ||
| pywebpush expects a synchronous API, while we use an asynchronous API. |
sygnal/webpushpushkin.py
Outdated
| @@ -363,8 +365,6 @@ class HttpResponseWrapper: | |||
| in the background. | |||
There was a problem hiding this comment.
it now doesn't really happen "in the background", afaict? it's more that it is deferred until later.
How about:
To keep pywebpush happy we present it with some hardcoded values that
make its assertions pass even though the HTTP request has not yet been
made.
There was a problem hiding this comment.
Indeed, I forgot to update this as the async request was fired immediately before but now is deferred to the execute method 👍 Have adopted your suggestion.
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Sygnal 0.9.3 (2021-04-22) ========================= Features -------- - Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212)) - WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213)) Bugfixes -------- - Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216)) - Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220)) Updates to the Docker image --------------------------- - Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208)) Improved Documentation ---------------------- - Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188)) - Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193)) - Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215)) Internal Changes ---------------- - Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193)) - Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194)) - Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207)) - Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219)) - Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214)) - Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217)) Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
Related to #186, based off #212 :
TopicheaderUrgencyheader based on the notification prio field.