Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Do checks on aliases for incoming m.room.aliases events #5128

Merged
merged 14 commits into from
May 8, 2019

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented May 2, 2019

Follow-up to #5124

Also added a bunch of checks to make sure everything (both the stuff added on #5124 and this PR) works as intended.

@babolivier babolivier requested a review from a team May 2, 2019 15:34
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #5128 into develop will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           develop    #5128      +/-   ##
===========================================
+ Coverage    61.69%   61.74%   +0.04%     
===========================================
  Files          336      335       -1     
  Lines        34549    34525      -24     
  Branches      5674     5678       +4     
===========================================
+ Hits         21316    21318       +2     
+ Misses       11702    11681      -21     
+ Partials      1531     1526       -5

richvdh
richvdh previously requested changes May 2, 2019
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
tests/rest/client/v1/test_directory.py Outdated Show resolved Hide resolved
@babolivier babolivier requested a review from a team May 3, 2019 13:07
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions about the comments; otherwise lgtm.

synapse/events/validator.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Show resolved Hide resolved
@babolivier babolivier requested a review from a team May 8, 2019 15:19
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@babolivier babolivier merged commit 1473058 into develop May 8, 2019
anoadragon453 added a commit that referenced this pull request May 10, 2019
* develop: (45 commits)
  URL preview blacklisting fixes (#5155)
  Revert 085ae34
  Add a DUMMY stage to captcha-only registration flow
  Make Prometheus snippet less confusing on the metrics collection doc (#4288)
  Set syslog identifiers in systemd units (#5023)
  Run Black on the tests again (#5170)
  Add AllowEncodedSlashes to apache (#5068)
  remove instructions for jessie installation (#5164)
  Run `black` on per_destination_queue
  Limit the number of EDUs in transactions to 100 as expected by receiver (#5138)
  Fix bogus imports in tests (#5154)
  add options to require an access_token to GET /profile and /publicRooms on CS API (#5083)
  Do checks on aliases for incoming m.room.aliases events (#5128)
  Remove the requirement to authenticate for /admin/server_version. (#5122)
  Fix spelling in server notices admin API docs (#5142)
  Fix sample config
  0.99.3.2
  include disco in deb build target list
  changelog
  Debian: we now need libpq-dev.
  ...
@babolivier babolivier deleted the babolivier/aliases branch September 27, 2019 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants