This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
URL preview blacklisting fixes #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Fix bogus imports in tests (#5154)
anoadragon453
force-pushed
the
anoa/blacklist_fixes
branch
from
550f0eb
to
8e0817e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5155 +/- ##
===========================================
+ Coverage 61.74% 61.74% +<.01%
===========================================
Files 336 336
Lines 34632 34636 +4
Branches 5688 5691 +3
===========================================
+ Hits 21383 21387 +4
Misses 11721 11721
Partials 1528 1528 |
richvdh
approved these changes
May 9, 2019
changelog.d/5155.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Prevent an exception from being raised in a IResolutionReceiver and use a more generic error message for blacklisted URL previews. | |||
There was a problem hiding this comment.
I'd call it a misc to be honest, unless we can think of a way to phrase it in a way that a user might recognise as a bugfix.
anoadragon453
added a commit
that referenced
this pull request
May 10, 2019
* develop: (45 commits) URL preview blacklisting fixes (#5155) Revert 085ae34 Add a DUMMY stage to captcha-only registration flow Make Prometheus snippet less confusing on the metrics collection doc (#4288) Set syslog identifiers in systemd units (#5023) Run Black on the tests again (#5170) Add AllowEncodedSlashes to apache (#5068) remove instructions for jessie installation (#5164) Run `black` on per_destination_queue Limit the number of EDUs in transactions to 100 as expected by receiver (#5138) Fix bogus imports in tests (#5154) add options to require an access_token to GET /profile and /publicRooms on CS API (#5083) Do checks on aliases for incoming m.room.aliases events (#5128) Remove the requirement to authenticate for /admin/server_version. (#5122) Fix spelling in server notices admin API docs (#5142) Fix sample config 0.99.3.2 include disco in deb build target list changelog Debian: we now need libpq-dev. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #5043
Prevents a SynapseError being raised inside of a
IResolutionReceiverand instead opts to just return 0 results. This thus means that we have to lump a failed lookup and a blacklisted lookup together with the same error message, but the substitute should be generic enough to cover both cases.