refactor: remove the filter of the time in the announcement
#1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR for issue : #1128
Refactors the
AnnouncementWorkflowNotifier
to remove the time-based filtering from the announcement display logic.Description
This change simplifies the process of handling announcements by removing the time filter that restricted announcements to their start and end times. Now, all provided announcements are considered eligible for display without time constraints. This modification is expected to streamline the display process and reduce the complexity of the code.
Tests
🧪 Use case 1
💬 Description:
Tested the announcements display in both linear and repeated modes to ensure that all announcements are now considered without time filtering. Verified that announcements outside their previously defined time frames are displayed correctly.
📷 Screenshots or GIFs (if applicable):
(Screenshots or GIFs showing the announcement display without time filtering can be added here.)
Checklist: