Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the filter of the time in the announcement #1129

Merged
merged 1 commit into from
May 3, 2024

Conversation

YassinNouh21
Copy link
Contributor

📝 Summary

This PR for issue : #1128
Refactors the AnnouncementWorkflowNotifier to remove the time-based filtering from the announcement display logic.

Description

This change simplifies the process of handling announcements by removing the time filter that restricted announcements to their start and end times. Now, all provided announcements are considered eligible for display without time constraints. This modification is expected to streamline the display process and reduce the complexity of the code.

Tests

🧪 Use case 1

💬 Description:
Tested the announcements display in both linear and repeated modes to ensure that all announcements are now considered without time filtering. Verified that announcements outside their previously defined time frames are displayed correctly.

📷 Screenshots or GIFs (if applicable):
(Screenshots or GIFs showing the announcement display without time filtering can be added here.)

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

Copy link
Contributor

@ghassenbenzahra123 ghassenbenzahra123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghassenbenzahra123 ghassenbenzahra123 merged commit 7bf1b0d into main May 3, 2024
1 check passed
@ghassenbenzahra123 ghassenbenzahra123 deleted the refactor/remove_announcement_time_filter branch May 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants