Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spread operator not working. #145

Closed
sorahn opened this issue Jan 27, 2016 · 5 comments
Closed

Spread operator not working. #145

sorahn opened this issue Jan 27, 2016 · 5 comments

Comments

@sorahn
Copy link

sorahn commented Jan 27, 2016

Doesn't look like the spread operator syntax is very happy right now.

function API_URL (base, endpoint, filters = {}) {
  return base.concat(endpoint, '?', serialize({...filters, json: 1}))
}

results in: SearchActions.js: Error: Line 29: Unexpected token ...
@bcomnes
Copy link
Collaborator

bcomnes commented Jan 27, 2016

The formatter basically doesn't have support for ES6 yet. We hope to correct this soon.

@sorahn
Copy link
Author

sorahn commented Jan 28, 2016

Yeah, I Think I found out after some more googling last night that this an espree issue. Thanks for the quick reply. :)

@yoshuawuyts
Copy link

It appears the object rest spread was added for the v0.8.0 milestone in Sept 2015, it doesn't appear to be working on more complicated uses tho

helloyou2012 added a commit to helloyou2012/esformatter-semicolon-first that referenced this issue Jul 7, 2016
@helloyou2012
allow experimental object rest/spread
8ba889b 
bug fix for: max-mapper/standard-format#145
@helloyou2012 helloyou2012 mentioned this issue Jul 7, 2016
Closed
millermedeiros pushed a commit to millermedeiros/esformatter-semicolon-first that referenced this issue Aug 7, 2016
@helloyou2012 @millermedeiros
add test for object rest/spread. closes #4
a3f0180 
see max-mapper/standard-format#145
@millermedeiros
Copy link

just released [email protected] with the fix!

@feross
Copy link
Collaborator

feross commented Aug 7, 2016

Nice!

@feross feross closed this as completed Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@feross @millermedeiros @bcomnes @sorahn @yoshuawuyts