-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow experimental object rest/spread #4
Conversation
can you add a test to avoid regressions? https://github.com/millermedeiros/esformatter-semicolon-first/tree/master/test/compare - just need to include an example on the input and output files and run
the best fix would be to replace espree with esformatter-parser, but this also works. |
Ok, I will add test case. |
// comment | ||
;[7, 8].forEach(doStuff) | ||
|
||
var y = 8 | ||
;(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm.. weird that this behavior changed. I would not expect the code to be formatted this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before that, this behavior have changed. Maybe espree
have changed. I'm checking.
Source :
After
|
uhm, I'll check this later. seems really weird. I'm sure behavior was fine previously. maybe esformatter is doing more stuff than before... or maybe I should just add the |
@helloyou2012 I ended up updating the parser and using your test cases (did some aggressive rebase but kept you as the commit author) thanks a lot for bringing this into my attention. I'm not using this plugin on my own projects (I like semicolons) so I would not notice it was broken. Cheers! |
just released v1.2.0 with the fix! |
bug fix for: max-mapper/standard-format#145