Small code cleanup #107
Merged
Small code cleanup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatted code only needs to be cast to a string in one place. Other uses can use the byte array.
This field is only used in one function which can accept the value as an argument
This condition is already checked 6 lines above in the same scope
Use an early return instead of variable to make hasDuplicateAliases easier to read.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been a user of this project for a while and I just started taking a look at the code. I noticed a few unused things, and functions that could be simplified a bit.
Each commit is a distinct small cleanup with a commit message that should hopefully explain it. If you prefer I would be happy to drop one or more of the commits, or squash the commits to a single commit.