Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small code cleanup #107

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Small code cleanup #107

merged 6 commits into from
Jan 8, 2019

Commits on Dec 25, 2018

  1. Remove unnecessary cast to string 

    Formatted code only needs to be cast to a string in one place. Other uses
can use the byte array.
    @dnephin
    dnephin committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    7375d06 View commit details
    Browse the repository at this point in the history

  2. Remove unused function export()

    @dnephin
    dnephin committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    92ac904 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Removed unused fields from Method

    @dnephin
    dnephin committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    ad476ce View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary WorkingDirectory field 

    This field is only used in one function which can accept the value as
an argument
    @dnephin
    dnephin committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    41a230d View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Remove duplicate null check 

    This condition is already checked 6 lines above in the same scope
    @dnephin
    dnephin committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    bf2163e View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary variable 

    Use an early return instead of variable to make hasDuplicateAliases
easier to read.
    @dnephin
    dnephin committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    1c19597 View commit details
    Browse the repository at this point in the history