Rails 6 fixes #951

damianlegawiec · 2019-05-02T14:05:46Z

No description provided.

… is deprecated and will be removed from Rails 6.1

igorkasyanchuk · 2019-05-03T21:49:56Z

with Rails 6 it doesn't work, see travis.ci logs.

…s 6.0 to core.rb

Fix/specs for rails 6

damianlegawiec · 2019-05-23T08:56:55Z

@igorkasyanchuk fixed!

igorkasyanchuk · 2019-05-23T10:39:12Z

great!

dankmitchell · 2019-06-19T20:54:28Z

Nice work!

seuros · 2019-06-19T20:57:26Z

We need to poing out in the changelog before pushing a new version out.
I see that tag_list changed it format in rails 6

behindthebid · 2019-06-27T01:20:14Z

+1

gkubaryk · 2019-06-28T16:07:19Z

can we also update the validator in lib/acts_as_taggable_on/tag.rb as such:

-    validates_uniqueness_of :name, if: :validates_name_uniqueness?
+    validates_uniqueness_of :name, if: :validates_name_uniqueness?, case_sensitive: true

This will address the deprecation warning:
DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. To continue case sensitive comparison on the :name attribute in ActsAsTaggableOn::Tag model, pass case_sensitive: true option explicitly to the uniqueness validator.

seuros · 2019-06-28T16:54:19Z

@gkubaryk i don't think tags should be case_sensitive.

gkubaryk · 2019-06-28T17:00:24Z

@seuros i have no strong opinion either way; the important thing (to me) is to set it to something so that the behavior is defined moving forward. the deprecation warning implied to me that it's silently been acting case sensitive and no longer will in the future. if you have a different reading of it or if we should take the opportunity to explicitly set it false, no argument here. :)

taf2 · 2019-06-28T17:07:21Z

Pretty sure the default is case sensitive false

seuros · 2019-06-28T18:00:59Z

@taf2 , When you use case_sensitive : false, the column is wrapped with lower() function in both side to remove sensitivity.
You dont need it if your field is already case insensitive eq citext.

spec/acts_as_taggable_on/dirty_spec.rb

murb · 2019-07-14T18:58:00Z

lib/acts_as_taggable_on/taggable/core.rb

+                if Rails.version < "6.0.0.beta1"
+                  set_attribute_was('#{tag_type}_list', #{tag_type}_list)
+                else
+                  duplicated_mutations_from_database.change_to_attribute('#{tag_type}_list')


Are you sure this is even working? I get the same result without it.

tbuehl

The Rails version check needs to be fixed to work with the official Rails 6 release.

I made a PR for this: spark-solutions#2

lib/acts_as_taggable_on/taggable/core.rb

tbuehl · 2019-08-19T11:47:15Z

For anyone on Rails 6 and as long as this PR isn't updated, here is a working solution:

https://github.com/tbuehl/acts-as-taggable-on/tree/fix/rails-6-and-failing-specs

use Gem::Version object to compare rails version instead of string

use Gem::Version object instead of string in specs

masonhensley · 2019-08-27T01:58:51Z

Appraisals

@@ -11,5 +11,5 @@ appraise 'activerecord-5.0' do
 end

 appraise 'activerecord-6.0' do
-  gem 'activerecord', "~> 6.0.0.beta1"
+  gem 'activerecord', "~> 6.0.0.rc1"


@damianlegawiec - thanks for the MR contribution!

Should this be bumped to 6.0.0 instead of 6.0.0.rc1? https://rubygems.org/gems/activerecord/versions/6.0.0

masonhensley · 2019-08-27T01:59:49Z

gemfiles/activerecord_6.0.gemfile

@@ -2,16 +2,18 @@

 source "https://rubygems.org"

-gem "activerecord", "~> 6.0.0.beta1"
+gem "activerecord", "~> 6.0.0.rc1"


@damianlegawiec - dupe comment...

Should this be bumped to 6.0.0 instead of 6.0.0.rc1? https://rubygems.org/gems/activerecord/versions/6.0.0

masonhensley · 2019-08-27T02:01:51Z

spec/acts_as_taggable_on/dirty_spec.rb

@@ -18,6 +18,7 @@
      end

      it 'should show changes of freshly initialized dirty object' do
+        pending if Gem.loaded_specs["rails"].version >= Gem::Version.new("6.0.0.beta1")


@damianlegawiec - one last one

Should this be bumped to 6.0.0 instead of 6.0.0.beta1?

Since acts-as-taggable-on still doesn't support Rails 6.0 we will drop dependency on it and we'll release an extension later providing those featues. mbleigh/acts-as-taggable-on#951

edd1312 · 2019-10-04T03:48:53Z

I changed the core.rb file to:

if self.class.preserve_tag_order? || parsed_new_list.sort != #{tag_type}_list.sort
                # set_attribute_was('#{tag_type}_list', #{tag_type}_list)
                attribute_will_change! "#{tag_type}_list"
                save
                write_attribute("#{tag_type}_list", parsed_new_list)
              end

and it works !!!

wpliao1989 · 2020-02-24T21:18:44Z

can we also update the validator in lib/acts_as_taggable_on/tag.rb as such:
-    validates_uniqueness_of :name, if: :validates_name_uniqueness?
+    validates_uniqueness_of :name, if: :validates_name_uniqueness?, case_sensitive: true
This will address the deprecation warning:
DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. To continue case sensitive comparison on the :name attribute in ActsAsTaggableOn::Tag model, pass case_sensitive: true option explicitly to the uniqueness validator.

I'm wondering if there's an official fix for this issue? This is generating a lot of deprecation warnings.

close mbleigh#951 fixes mbleigh#953 files mbleigh#961

curtp · 2020-05-04T15:46:22Z

We're using gem version 6.5.0 and we're seeing a lot of the deprecation warnings about the uniqueness validator.

fnguyen-tc · 2020-07-27T15:30:04Z

Please change to validates_uniqueness_of :name, if: :validates_name_uniqueness?, case_sensitive: true

damianlegawiec added 6 commits May 2, 2019 11:58

Fix failing Specs on Rails < 6 due to sqlite3 issue

4d9b488

update_attributes are deprecated in Rails 6.0 and will be removed in 6.1

8437c80

Targer Tails 6.0.0.rc1

dfb8061

Fixed MySQL migration in AR 6.0

98bf9b6

Use rspec-rails 4.0 for Rails 6.0

8236891

Fixed DEPRECATION WARNING: ActiveSupport::Multibyte::Unicode#downcase…

0528651

… is deprecated and will be removed from Rails 6.1

damianlegawiec marked this pull request as ready for review May 2, 2019 14:06

PSzyszkaSpark added 2 commits May 9, 2019 12:31

Adds duplicated_mutations_from_database method for rails gt or q rail…

c0bba87

…s 6.0 to core.rb

Corrects dirty_spec.rb for rails version gt or eq 6.0

47d87bd

PSzyszkaSpark mentioned this pull request May 9, 2019

Fix/specs for rails 6 spark-solutions/acts-as-taggable-on#1

Merged

Merge pull request #1 from spark-solutions/fix/specs_for_rails-6

22efcac

Fix/specs for rails 6

rolandoalvarado mentioned this pull request Jun 6, 2019

Added ignore_deleted option #958

Open

seuros added the feature label Jun 28, 2019

ernbrn mentioned this pull request Jun 30, 2019

Tag, you're it ernbrn/qwm-api#6

Closed

murb reviewed Jul 14, 2019

View reviewed changes

tbuehl suggested changes Aug 19, 2019

View reviewed changes

lib/acts_as_taggable_on/taggable/core.rb Outdated Show resolved Hide resolved

Oleg Leontiev added 2 commits August 19, 2019 15:31

use Gem::Version object to compare rails version instead of string

cf29db2

set proper rails version to compare

1fd1c6b

damianlegawiec and others added 3 commits August 19, 2019 16:30

Merge pull request #3 from spark-solutions/fix-rails-version-check

31063ff

use Gem::Version object to compare rails version instead of string

use Gem::Version object instead of string in specs

dc7526e

Merge pull request #4 from spark-solutions/fix-rails-version-check

1bd0f0d

use Gem::Version object instead of string in specs

masonhensley reviewed Aug 27, 2019

View reviewed changes

chhlga mentioned this pull request Aug 27, 2019

Remove acts as taggable on spree/spree#9491

Merged

seuros self-assigned this Aug 28, 2019

masonhensley mentioned this pull request Sep 15, 2019

Prepare to release 6.5 #968

Merged

seuros closed this in 950c010 Oct 29, 2019

rolandoalvarado pushed a commit to rolandoalvarado/acts-as-taggable-on that referenced this pull request Mar 5, 2020

Release 6.5 (mbleigh#968)

391650a

close mbleigh#951 fixes mbleigh#953 files mbleigh#961

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 6 fixes #951

Rails 6 fixes #951

damianlegawiec commented May 2, 2019

igorkasyanchuk commented May 3, 2019

damianlegawiec commented May 23, 2019

igorkasyanchuk commented May 23, 2019

dankmitchell commented Jun 19, 2019

seuros commented Jun 19, 2019

behindthebid commented Jun 27, 2019

gkubaryk commented Jun 28, 2019

seuros commented Jun 28, 2019

gkubaryk commented Jun 28, 2019

taf2 commented Jun 28, 2019

seuros commented Jun 28, 2019

murb Jul 14, 2019

tbuehl left a comment •

edited

Loading

tbuehl commented Aug 19, 2019

masonhensley Aug 27, 2019

masonhensley Aug 27, 2019

masonhensley Aug 27, 2019

edd1312 commented Oct 4, 2019 •

edited

Loading

wpliao1989 commented Feb 24, 2020

curtp commented May 4, 2020

fnguyen-tc commented Jul 27, 2020 •

edited

Loading

Rails 6 fixes #951

Rails 6 fixes #951

Conversation

damianlegawiec commented May 2, 2019

igorkasyanchuk commented May 3, 2019

damianlegawiec commented May 23, 2019

igorkasyanchuk commented May 23, 2019

dankmitchell commented Jun 19, 2019

seuros commented Jun 19, 2019

behindthebid commented Jun 27, 2019

gkubaryk commented Jun 28, 2019

seuros commented Jun 28, 2019

gkubaryk commented Jun 28, 2019

taf2 commented Jun 28, 2019

seuros commented Jun 28, 2019

murb Jul 14, 2019

Choose a reason for hiding this comment

tbuehl left a comment • edited Loading

Choose a reason for hiding this comment

tbuehl commented Aug 19, 2019

masonhensley Aug 27, 2019

Choose a reason for hiding this comment

masonhensley Aug 27, 2019

Choose a reason for hiding this comment

masonhensley Aug 27, 2019

Choose a reason for hiding this comment

edd1312 commented Oct 4, 2019 • edited Loading

and it works !!!

wpliao1989 commented Feb 24, 2020

curtp commented May 4, 2020

fnguyen-tc commented Jul 27, 2020 • edited Loading

tbuehl left a comment •

edited

Loading

edd1312 commented Oct 4, 2019 •

edited

Loading

fnguyen-tc commented Jul 27, 2020 •

edited

Loading