Added ignore_deleted option #958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
8 times, most recently
from
b6838a0
to
8e49837
Compare
|
do you think the test will work if I remove the gem and require directive? @gzzengwei Or maybe you have other idea. |
|
There are 6 failed CI Build which will be fix by this MR: #951 courtesy of @damianlegawiec |
|
@gzzengwei in our cases we don't have specific version but as stated in Contributing.md docs test needs to be pass to be merge. |
|
@damianlegawiec I have pick few of your changes to make CI green. I will just rebase with master once your PR is merged. Thanks in advance. |
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
2 times, most recently
from
23e71e8
to
499f66f
Compare
brissenden
reviewed
Jun 8, 2019
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
3 times, most recently
from
f444280
to
96b8253
Compare
rolandoalvarado
changed the title
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
from
96b8253
to
c8d191f
Compare
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
3 times, most recently
from
85f351d
to
958a56f
Compare
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
2 times, most recently
from
ac9d8b4
to
0ebed56
Compare
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
2 times, most recently
from
9a44406
to
0ebed56
Compare
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
3 times, most recently
from
0ebed56
to
373f05f
Compare
Merged with upstream Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Updated CHANGELOG Fixed Gem::LoadError: Specified 'sqlite3' Fixed spec Removed sqlite3 from gem spec Fixed incorrect tagging alias table Refactor specs Added sqlite3 to Gemfile Fixed sqlite3 version for active_record 5.0 ref Remove 'acts_as_paranoid' as dependency and add to Gemfile Transferred acts_as_paranoid to invidividual active record versions Minor changes to make CI pass Minor change Fixed spec Removed act_as_paranoid gem Removed act_as_paranoid gem Added missing methods
Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Updated CHANGELOG Fixed Gem::LoadError: Specified 'sqlite3' Fixed spec Removed sqlite3 from gem spec Fixed incorrect tagging alias table Refactor specs Added sqlite3 to Gemfile Fixed sqlite3 version for active_record 5.0 ref Remove 'acts_as_paranoid' as dependency and add to Gemfile Transferred acts_as_paranoid to invidividual active record versions Minor changes to make CI pass Minor change Fixed spec
Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Updated CHANGELOG Fixed Gem::LoadError: Specified 'sqlite3' Fixed spec Removed sqlite3 from gem spec Fixed incorrect tagging alias table Refactor specs Added sqlite3 to Gemfile Fixed sqlite3 version for active_record 5.0 ref Remove 'acts_as_paranoid' as dependency and add to Gemfile Transferred acts_as_paranoid to invidividual active record versions Minor changes to make CI pass Minor change Fixed spec
Added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Integrated act_as_paranoid and added ignore_deleted option Updated CHANGELOG Fixed Gem::LoadError: Specified 'sqlite3' Fixed spec Removed sqlite3 from gem spec Fixed incorrect tagging alias table Refactor specs Added sqlite3 to Gemfile Fixed sqlite3 version for active_record 5.0 ref Remove 'acts_as_paranoid' as dependency and add to Gemfile Transferred acts_as_paranoid to invidividual active record versions Minor changes to make CI pass Minor change Fixed spec Removed act_as_paranoid gem Adjusted specs Added checking for deleted_at column and added specs Updated specs Fixed incorrect variable and method used
Make sure alias table is unique to prevent not unique table/alias error. This is just a quick fix. I’m open for any suggestion.
rolandoalvarado
force-pushed
the
feature/ignore_deleted_option
branch
from
373f05f
to
446862e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.