Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecate Unicode#downcase/upcase/swapcase. #962

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sin-to-jin
Copy link

DEPRECATION WARNING: ActiveSupport::Multibyte::Unicode#downcase is deprecated and will be removed from Rails 6.1. Use String methods directly. (called from unicode_downcase at /vendor/bundle/ruby/2.6.0/bundler/gems/acts-as-taggable-on-d01c315f616b/lib/acts_as_taggable_on/tag.rb:126)

ref rails/rails@619b2ae

sin added 6 commits August 19, 2019 19:05
To fix mbleigh#955
When the Rails version is 6.0.0, it becomes true, so I want to skip set_attribute_was.
…tch-1

When Rails version is 6.0.0, skip this.
lib/acts_as_taggable_on/taggable/core.rb Outdated Show resolved Hide resolved
lib/acts_as_taggable_on/taggable/core.rb Outdated Show resolved Hide resolved
@sin-to-jin
Copy link
Author

Reverted because there was an extra commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants