Updated some dependencies #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akauppi
commented
Jul 19, 2018
| val enumeratumVersion = "1.5.12" | ||
| val enumeratumCirceVersion = "1.5.14" | ||
| val akkaStreamJson = "3.4.0" | ||
|
|
akauppi
commented
Jul 19, 2018
| @@ -6,8 +6,6 @@ addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "2.3") | |||
|
|
|||
| addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "2.0.2") | |||
|
|
|||
| addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.8") | |||
|
|
|||
akauppi
commented
Jul 19, 2018
| @@ -3,9 +3,9 @@ name := "akka-streams-json" | |||
| val currentScalaVersion = "2.12.6" | |||
| val scala211Version = "2.11.11" | |||
| val circeVersion = "0.9.3" | |||
| val akkaVersion = "2.5.12" | |||
| val akkaHttpVersion = "10.1.1" | |||
| val jawnVersion = "0.11.1" | |||
There was a problem hiding this comment.
Updating jawnVersion broke sbt test, so I kept the existing version
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 4 4
Lines 63 63
Branches 4 4
=======================================
Hits 54 54
Misses 9 9Continue to review full report at Codecov.
|
|
Im currently on vacation so I will likely look into this early next week, I assume its not really urgent? |
|
Already done here #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some version bumps and cleanup that did not break the tests. See PR comments for more details.
Hint: this plugin is neat in keeping up with dependency versions. If interested, best installed as a global plugin.