Scala 2.13 support #6

anskarl · 2019-09-19T18:44:13Z

Updates library dependencies
Crossbuild for Scala 2.11, 2.12 and 2.13
For Scala 2.11 circe is version is 0.11.1, while for Scala 2.12 and 2.13 circe version is 0.12.1

- Updates library dependencies - Crossbuild for Scala 2.11, 2.12 and 2.13 - For Scala 2.11 circe version is 0.11.1, while for Scala 2.12 and 2.13 circe version is 0.12.1

anskarl · 2019-10-05T09:39:32Z

Hi @mdedetrich, any update?

mdedetrich · 2019-10-07T12:19:06Z

.gitignore

@@ -15,6 +15,8 @@ project/plugins/project/
 .history
 .cache
 .lib/
+.idea/


Can you delete these changes please? Its recommended to use a global .gitignore file for IDE specific files (see https://stackoverflow.com/questions/7335420/global-git-ignore)

mdedetrich

Also can you update version.sbt to 0.4.0

mdedetrich · 2019-10-07T12:22:56Z

@anskarl Thanks for the PR, kinda forgot about it (sorry about that). Just a couple of changes needed.

- remove ide-specific settings in gitignore

- adds scala 2.13 - changes to openjdk8 - updates sbt-scoverage in order to support 2.13

codecov · 2019-10-07T15:49:30Z

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           4        4           
  Lines          63       63           
  Branches        4        3    -1     
=======================================
  Hits           54       54           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867093d...e12a25e. Read the comment docs.

anskarl · 2019-10-07T15:55:02Z

Hi @mdedetrich, thank you for the review. I've made the requested changes and I've noticed that I haven't updated the travis.yml for Scala 2.13 as well as sbt-coverage. Therefore I have made few more additions regarding the CI and the code coverage. I have also switched to openjdk8 in travis.yml due to issues downloading oraclejdk8.

mdedetrich · 2019-10-08T10:13:21Z

.travis.yml


 scala:
  - 2.11.12
-  - 2.12.7
+  - 2.12.9
+  - 2.13.0


Can you use Scala 2.13.1 here?

unfortunately the latest version of sbt-scoverage does not work with Scala 2.13.1 (see issue scoverage/sbt-scoverage#295).

For example when building for Scala 2.13.1:

sbt ++2.13.1 clean coverage test coverageReport

result to a java.lang.NoSuchMethodError

[error] java.lang.NoSuchMethodError: scala.tools.nsc.Global.reporter()Lscala/tools/nsc/reporters/Reporter; [error] at scoverage.ScoverageInstrumentationComponent$$anon$1.run(plugin.scala:119) [error] at scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1506) [error] at scala.tools.nsc.Global$Run.compileUnits(Global.scala:1490) [error] at scala.tools.nsc.Global$Run.compileSources(Global.scala:1482) [error] at scala.tools.nsc.Global$Run.compile(Global.scala:1614) [error] at xsbt.CachedCompiler0.run(CompilerInterface.scala:130) [error] at xsbt.CachedCompiler0.run(CompilerInterface.scala:105) [error] at xsbt.CompilerInterface.run(CompilerInterface.scala:31) [error] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [error] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [error] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [error] at java.lang.reflect.Method.invoke(Method.java:498) [error] at sbt.internal.inc.AnalyzingCompiler.call(AnalyzingCompiler.scala:237) [error] at sbt.internal.inc.AnalyzingCompiler.compile(AnalyzingCompiler.scala:111) [error] at sbt.internal.inc.AnalyzingCompiler.compile(AnalyzingCompiler.scala:90) [error] at sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$3(MixedAnalyzingCompiler.scala:82) [error] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12) [error] at sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:133) [error] at sbt.internal.inc.MixedAnalyzingCompiler.compileScala$1(MixedAnalyzingCompiler.scala:73) [error] at sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:116) [error] at sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:307) [error] at sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:307) [error] at sbt.internal.inc.Incremental$.doCompile(Incremental.scala:106) [error] at sbt.internal.inc.Incremental$.$anonfun$compile$4(Incremental.scala:87) [error] at sbt.internal.inc.IncrementalCommon.recompileClasses(IncrementalCommon.scala:116) [error] at sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:63) [error] at sbt.internal.inc.Incremental$.$anonfun$compile$3(Incremental.scala:89) [error] at sbt.internal.inc.Incremental$.manageClassfiles(Incremental.scala:134) [error] at sbt.internal.inc.Incremental$.compile(Incremental.scala:80) [error] at sbt.internal.inc.IncrementalCompile$.apply(Compile.scala:67) [error] at sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:311) [error] at sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:269) [error] at sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:159) [error] at sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:238) [error] at sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:69) [error] at sbt.Defaults$.compileIncrementalTaskImpl(Defaults.scala:1549) [error] at sbt.Defaults$.$anonfun$compileIncrementalTask$1(Defaults.scala:1523) [error] at scala.Function1.$anonfun$compose$1(Function1.scala:44) [error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40) [error] at sbt.std.Transform$$anon$4.work(System.scala:67) [error] at sbt.Execute.$anonfun$submit$2(Execute.scala:269) [error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16) [error] at sbt.Execute.work(Execute.scala:278) [error] at sbt.Execute.$anonfun$submit$1(Execute.scala:269) [error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178) [error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:37) [error] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [error] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [error] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [error] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [error] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [error] at java.lang.Thread.run(Thread.java:748)

On the other hand, for Scala 2.13.0, sbt-scoverage works fine.

Okie dokie, we can update it later when they fix the problem then. Will release this PR tonight, thanks for the contribution!

mdedetrich · 2019-10-08T10:14:21Z

Thanks for the changes, just noticed one final thing.

mdedetrich · 2019-10-08T20:12:45Z

Okay so there are issues with sonatype right now (see https://status.sonatype.com/) so I will try and publish tomorrow

mdedetrich · 2019-10-08T23:11:28Z

Okay so sonatype is back up and I just published, should be on maven in ~1 hour

anskarl · 2019-10-09T04:19:41Z

Awesome! Thank you.

Adds Scala 2.13 support

e9650c3

- Updates library dependencies - Crossbuild for Scala 2.11, 2.12 and 2.13 - For Scala 2.11 circe version is 0.11.1, while for Scala 2.12 and 2.13 circe version is 0.12.1

mdedetrich requested changes Oct 7, 2019

View reviewed changes

anskarl added 2 commits October 7, 2019 14:55

Setting version to 0.4.0

d747c58

- remove ide-specific settings in gitignore

updates travis.yml

e12a25e

- adds scala 2.13 - changes to openjdk8 - updates sbt-scoverage in order to support 2.13

anskarl force-pushed the scala_2_13 branch from c8bb8d5 to e12a25e Compare October 7, 2019 15:49

mdedetrich requested changes Oct 8, 2019

View reviewed changes

mdedetrich approved these changes Oct 8, 2019

View reviewed changes

mdedetrich merged commit 4667435 into mdedetrich:master Oct 8, 2019

This was referenced Oct 9, 2019

Update to latest versions, add Scala 2.13 #5

Closed

Updated some dependencies #3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scala 2.13 support #6

Scala 2.13 support #6

anskarl commented Sep 19, 2019

anskarl commented Oct 5, 2019

mdedetrich Oct 7, 2019

mdedetrich left a comment

mdedetrich commented Oct 7, 2019

codecov bot commented Oct 7, 2019 •

edited

Loading

anskarl commented Oct 7, 2019

mdedetrich Oct 8, 2019 •

edited

Loading

anskarl Oct 8, 2019

mdedetrich Oct 8, 2019

mdedetrich commented Oct 8, 2019

mdedetrich commented Oct 8, 2019

mdedetrich commented Oct 8, 2019

anskarl commented Oct 9, 2019

Scala 2.13 support #6

Scala 2.13 support #6

Conversation

anskarl commented Sep 19, 2019

anskarl commented Oct 5, 2019

mdedetrich Oct 7, 2019

Choose a reason for hiding this comment

mdedetrich left a comment

Choose a reason for hiding this comment

mdedetrich commented Oct 7, 2019

codecov bot commented Oct 7, 2019 • edited Loading

Codecov Report

anskarl commented Oct 7, 2019

mdedetrich Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

anskarl Oct 8, 2019

Choose a reason for hiding this comment

mdedetrich Oct 8, 2019

Choose a reason for hiding this comment

mdedetrich commented Oct 8, 2019

mdedetrich commented Oct 8, 2019

mdedetrich commented Oct 8, 2019

anskarl commented Oct 9, 2019

codecov bot commented Oct 7, 2019 •

edited

Loading

mdedetrich Oct 8, 2019 •

edited

Loading