Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unimplemented SVG color-profile & solidcolor elements #10515

Merged
merged 1 commit into from
May 20, 2021

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented May 18, 2021

The SVG color-profile and solidcolor elements have never been implemented in any browser engines, so this change removes the data for the elements as well as the data for their associated APIs. Related: #6768

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG labels May 18, 2021
@nutza978
Copy link

@apple-web-evangelist

The SVG color-profile & solidcolor elements have never been implemented
in any browser engines, so this change removes the data for the elements
as well as the data for their associated APIs.

Related: mdn#6768
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/SVG-unimplemented-remove branch from c6fdca5 to 4b86ee8 Compare May 19, 2021 22:22
@sideshowbarker
Copy link
Collaborator Author

@apple-web-evangelist On the off chance that @nutza978 isn’t just some junk account posting random comment spam and that instead there’s some question about whether these proposed removals would be dropping data for anything actually implemented in WebKit: I checked he WebKit sources before raising this, and confirmed there’s no current code in WebKit for SVGColorProfileElement or SVGSolidcolorElement — and no corresponding code for the elements.

We have a related issue at #6768 which initially included a proposal to drop data from BCD for 17 SVG elements/APIs due to them not being implemented in any engines. But from subsequent investigation and testing it turned out that 15 of those had actually been implemented in WebKit (and only WebKit).

SVGColorProfileElement and SVGSolidcolorElement are the only ones from that initial #6768 list that are in fact completely unimplemented.

@saschanaz
Copy link
Contributor

On the off chance that @nutza978 isn’t just some junk account

I highly suspect it is per #10532 🤔

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Thank you! 🎉

(The spam accounts thing is getting to be quite annoying. I'm seriously considering turning on the temporary interaction limits for new users.)

ddbeck added a commit to ddbeck/mdn-content that referenced this pull request May 20, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented May 20, 2021

Opened mdn/content#5147 for corresponding content removal.

@ddbeck ddbeck merged commit ffa873c into mdn:main May 20, 2021
chrisdavidmills pushed a commit to mdn/content that referenced this pull request May 20, 2021
* Remove unimplemented SVG color-profile and solidcolor

Content changes to correspond to BCD:
mdn/browser-compat-data#10515

* Fix attribute usage miscounts

* Make xlink:type consistent
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 20, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 20, 2021
ddbeck added a commit that referenced this pull request May 20, 2021
* Bump version to v3.3.4
* Add release note for #10353
* Add release note for #10347
* Add release note for #10336
* Add release note for #10415
* Add release note for #10417
* Add release note for #10449
* Add release note for #9933
* Add release note for #10354
* Add release notes for #6944
* Add release note for #10522
* Add release note for #10536
* Add release note for #10539
* Add release note for #10515
* Add release note for #10506
* Add release note for #10291
* Add release note for #10421
* Add release note for #10545
* Add stats
@sideshowbarker sideshowbarker deleted the sideshowbarker/SVG-unimplemented-remove branch May 21, 2021 03:18
@sideshowbarker
Copy link
Collaborator Author

(The spam accounts thing is getting to be quite annoying. I'm seriously considering turning on the temporary interaction limits for new users.)

We could also consider blocking the offending accounts. That’d at least prevent repeat offenses (such at the case with the account that posted to this issue). But that said, I think we can’t do blocking per-repo but instead need to block accounts per-org. So that’d mean we’d need somebody with admin perms for the @mdn org to add the accounts to the org-wide block list.

https://github.com/organizations/mdn/settings/user_blocks is where the UI for it would be (for somebody with the right perms)

@ddbeck
Copy link
Collaborator

ddbeck commented May 25, 2021

@sideshowbarker Yes, we could use this more aggressively. I've asked for repeat offenders to be blocked from time to time, but I don't have the privileges to do it myself. I'll look into this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants