Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix ChildNode #10506

Merged
merged 4 commits into from
May 20, 2021
Merged

Demix ChildNode #10506

merged 4 commits into from
May 20, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented May 17, 2021

See #8929 for background.

IDL: https://dom.spec.whatwg.org/#interface-childnode

interface mixin ChildNode {
  [CEReactions, Unscopable] undefined before((Node or DOMString)... nodes);
  [CEReactions, Unscopable] undefined after((Node or DOMString)... nodes);
  [CEReactions, Unscopable] undefined replaceWith((Node or DOMString)... nodes);
  [CEReactions, Unscopable] undefined remove();
};
DocumentType includes ChildNode;
Element includes ChildNode;
CharacterData includes ChildNode;

So we need to expose compat data on DocumentType, Element, and CharacterData and remove the abstract compat data on ChildNode.

This PR assumes the same compat data on all specific interfaces.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 17, 2021
api/CharacterData.json Show resolved Hide resolved
api/CharacterData.json Outdated Show resolved Hide resolved
api/DocumentType.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/CharacterData.json Outdated Show resolved Hide resolved
api/CharacterData.json Outdated Show resolved Hide resolved
api/DocumentType.json Outdated Show resolved Hide resolved
api/DocumentType.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
Co-authored-by: Philip Jägenstedt <[email protected]>
}
},
"status": {
"experimental": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of these count as experimental at this point :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I fixed this in content, too.

@foolip foolip merged commit 2569c72 into mdn:main May 20, 2021
@Elchi3 Elchi3 deleted the demix-childnode branch May 20, 2021 14:07
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 20, 2021
ddbeck added a commit that referenced this pull request May 20, 2021
* Bump version to v3.3.4
* Add release note for #10353
* Add release note for #10347
* Add release note for #10336
* Add release note for #10415
* Add release note for #10417
* Add release note for #10449
* Add release note for #9933
* Add release note for #10354
* Add release notes for #6944
* Add release note for #10522
* Add release note for #10536
* Add release note for #10539
* Add release note for #10515
* Add release note for #10506
* Add release note for #10291
* Add release note for #10421
* Add release note for #10545
* Add stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants