Pagemacro filesystemflags #10092
Merged
Pagemacro filesystemflags #10092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
ddbeck and
jpmedley
and removed request for
a team
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
wbamberg
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page macro removal - part of #3196
The
FileSystemFlagsis a dictionary, which had acreateand anexclusiveproperty that were importing a table from the parent.What I have done is simply deleted the two sub property docs (and redirected to parent) to delete the page macro.
Why? This is a dictionary, and we plan to remove dictionaries from MDN to where they are used. This is a half way house to that since eventually the sub-pages would be removed anyway. I haven't done the extra step of duplicating the dictionary where it is use yet though. Figured that can wait until the associated work was done in BCD.