Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the {{page}} macro #3196

Closed
wbamberg opened this issue Mar 16, 2021 · 12 comments · Fixed by #13142
Closed

Remove the {{page}} macro #3196

wbamberg opened this issue Mar 16, 2021 · 12 comments · Fixed by #13142
Assignees

Comments

@wbamberg
Copy link
Collaborator

wbamberg commented Mar 16, 2021

This came out of #3008. We should remove the {{page}} macro from MDN: it's a common source of content problems.

We will need to look through the 370-odd places where it's used, and decide what to do in each case. Probably either:

  • duplicate the content
  • have the content in one place and just use links to it in the other places

@escattone

@wbamberg wbamberg added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 16, 2021
@escattone
Copy link
Contributor

Thanks for creating this @wbamberg. It'll be nice to eventually resolve this and rid ourselves of this macro.

@wbamberg wbamberg self-assigned this Mar 17, 2021
@hamishwillee
Copy link
Collaborator

Happy to help hack away at this with you (once the broad discussion of "how" we do this is resolved).

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 23, 2021

FYI, Page macro search got me 420 hits in 351 files (of 11702 searched). Down to 385 hits in 316 files following easy fixes in #3392.

@wbamberg
Copy link
Collaborator Author

@hamishwillee , this is amazing work!

@wbamberg
Copy link
Collaborator Author

Do we really only have about 15 of these left?!

./files/en-us/web/api/rtcsessiondescription/rtcsessiondescription/index.md:        `RTCSdpType` enum; it must have one of the following values:{{page("/en-US/docs/Web/API/RTCSessionDescription", "RTCSdpType")}}
./files/en-us/web/api/rtcicetransport/state/index.md:{{page("/en-US/docs/Web/API/RTCIceTransportState", "Values")}}
./files/en-us/web/api/rtcicetransport/role/index.md:{{page("/en-US/docs/Web/API/RTCIceRole", "Values")}}
./files/en-us/web/api/rtcrtpsendparameters/encodings/index.md:{{page("/en-US/docs/Web/API/RTCRtpEncodingParameters", "Properties")}}
./files/en-us/web/api/rtcrtpcapabilities/index.md:{{page("/en-US/docs/Web/API/RTCRtpCodecCapability", "Properties")}}
./files/en-us/web/api/rtcstatsreport/index.md:{{page("/en-US/docs/Web/API/RTCStats", "Properties")}}
./files/en-us/web/api/rtcstatsreport/index.md:{{page("/en-US/docs/Web/API/RTCStatsType", "Values")}}
./files/en-us/web/api/rtcicecandidatestats/networktype/index.md:{{page("/en-US/docs/Web/API/RTCNetworkType", "Values")}}
./files/en-us/web/api/xrinputsourceevent/xrinputsourceevent/index.md:{{page("/en-US/docs/Web/API/XRInputSourceEvent", "Event types")}}
./files/en-us/web/api/htmlformelement/elements/index.md:{{page("/en-US/docs/Web/API/HTMLFormElement", "Elements that are considered form controls")}}
./files/en-us/web/api/mediatrackconstraints/facingmode/index.md:{{page("/en-US/docs/Web/API/MediaTrackSettings/facingMode", "VideoFacingModeEnum")}}
./files/en-us/web/api/rtciceserver/credentialtype/index.md:{{page("/en-US/docs/Web/API/RTCIceCredentialType", "Values")}}
./files/en-us/web/api/htmlvideoelement/videowidth/index.md:{{page("/en-US/docs/Web/API/HTMLVideoElement/videoHeight", "About intrinsic width and height", 0, 1)}}
./files/en-us/web/api/webgl_api/using_extensions/index.md:{{page("en-US/docs/Web/API/WebGL_API", "Extensions")}}
./files/en-us/web/api/paymentresponse/retry/index.md:    {{page("/en-US/docs/Web/API/PaymentValidationErrors", "Properties")}}

@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 20, 2022

Yes. I'm seeing 20 hits in 16 files. BUT - still in translations ...

@queengooborg
Copy link
Collaborator

Fixed by #15906!

@hamishwillee
Copy link
Collaborator

Well done all. This was a slog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants