Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transclusion from meta documentation #15906

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

teoli2003
Copy link
Contributor

This removes the last occurrences of the {{page}} and the associated meta-documentation.

This is a major milestone: 10 months ago we decided to get rid of this macro as it was fragile, but also a performance problem for yari. We still need to wait until it is gone from mdn/translated-content, as well as the removal of the other transclusion macro (see #15872) before our developers can celebrate (and work hard to make good use of this simplification).

We (mostly @hamishwillee – a big thumb up to you! – but also the whole team) worked hard in the background: we had more than 400 occurrences of these initially.

🍾 🥳 🎆

@teoli2003 teoli2003 requested a review from a team as a code owner May 11, 2022 12:23
@teoli2003 teoli2003 requested review from dipikabh and removed request for a team May 11, 2022 12:23
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Preview URLs

Flaws

URL: /en-US/docs/MDN/Structures/Macros/Other
Title: Other macros
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Source_Code/CVS
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/mozilla-central

External URLs

URL: /en-US/docs/MDN/Structures/Macros/Other
Title: Other macros
on GitHub

(this comment was updated 2022-05-11 14:20:38.113925)

@wbamberg
Copy link
Collaborator

wbamberg commented May 11, 2022

Fixes #3196 .

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation removal looks good to me, thanks!

@queengooborg queengooborg merged commit 9f80212 into main May 12, 2022
@queengooborg queengooborg deleted the teoli2003-patch-1 branch May 12, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants