AriaRoles: Remove pagemacro #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
chrisdavidmills
and removed request for
a team
chrisdavidmills
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up sidebar on all 37 AriaRoles docs (as part of removing
{{Page}}macro (FYI @wbamberg).In summary, all the aria role docs had
{{Page("/en-US/docs/Web/Accessibility/ARIA/Roles", "Subnav")}}which was supposed to generate the sidebar from the Subnav heading in parent doc. However "Subnav" sections got removed at some point as sidebars are done differently.Instead, this now uses the "Quick_links" section to generate the intended effect.
It also fixes a few broken links, and changes the names of some broken links to lower case (which may not have been necessary, but seemed consistent when I started, and is non harmful).
EDITED. Also added XPath comparison doc fix (only other case ofa page import of a subnav). I took the quicklinks from the XPath page - so it matches the expected sidebar.