Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of page macro in release notes #4666

Merged
merged 1 commit into from
May 4, 2021

Conversation

hamishwillee
Copy link
Collaborator

This is part of fixing #3196 (removing the page macro).

This replaces the developer tools inclusion from FF44, 45, 46, which has not worked as far as I can tell since 2017.

Information came from the wayback machine in the last good record:

The links all worked except for one - which I have traced and fixed.

@hamishwillee hamishwillee requested a review from a team as a code owner May 3, 2021 08:29
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team May 3, 2021 08:29
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/45
Title: Firefox 45 for developers
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Operators/Expression_closures does not exist
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/ComputedTiming does not exist
    • /en-US/docs/Web/API/MediaStream/removeTrack does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Creating_OpenSearch_plugins_for_Firefox

URL: /en-US/docs/Mozilla/Firefox/Releases/46
Title: Firefox 46 for developers
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/@font/font-display does not exist
    • /en-US/docs/Web/CSS/@font does not exist
    • /en-US/docs/Web/JavaScript/Reference/Operators/Array_comprehensions does not exist
    • /en-US/docs/Web/JavaScript/Reference/Operators/Generator_comprehensions does not exist
    • /en-US/docs/Web/API/AnimationEffectTimingReadOnly does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub
Flaw count: 20

  • macros:
    • /en-US/docs/Web/CSS/-moz-math-display does not exist
    • /en-US/docs/Web/CSS/-moz-window-shadow does not exist
    • /en-US/docs/Web/CSS/page does not exist
    • /en-US/docs/Web/CSS/size does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/noSuchMethod does not exist
    • and 10 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Using_the_application_cache
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Firefox_for_Android/API/Snackbars.jsm
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/cfx
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/jpm
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/cfx_to_jpm

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/45
Title: Firefox 45 for developers
on GitHub


URL: /en-US/docs/Mozilla/Firefox/Releases/46
Title: Firefox 46 for developers
on GitHub


URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@chrisdavidmills chrisdavidmills merged commit 1a84c98 into mdn:main May 4, 2021
@hamishwillee hamishwillee deleted the pagemacro_relnote branch May 4, 2021 22:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants