Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioBufferSourceNode: include SeeAlso rather than use page macro #4849

Merged
merged 1 commit into from
May 13, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 10, 2021

https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/buffer was using page macro to pull in See Also from https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode.

This replaces macro by duplicating the see also section. Also updates the docs for other AudioBufferSourceNode properties to match.

This is part of #3196

@hamishwillee hamishwillee requested a review from a team as a code owner May 10, 2021 02:07
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team May 10, 2021 02:07
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @hamishwillee !

@wbamberg wbamberg merged commit bec8fce into mdn:main May 13, 2021
@hamishwillee hamishwillee deleted the pagemacro_audiobuffersourcenode branch May 13, 2021 23:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants