Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioParamDescriptor - replace page macro with code fragment #4852

Merged
merged 3 commits into from
May 10, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 10, 2021

This is part of fixing #3196

The AudioParamDescriptor example was pulled from AudioWorkletNode/parameters using page macro. This cuts out just the relevant part of the example that shows this code being used and links to the larger example.

Further, the AudioWorkletProcessor.parameterDescriptors() static getter was pulling the values of AudioParamDescriptor using the page macro. Here I decided to just copy in the values. I could have just linked but really it seems like duplicating is worthwhile for understanding easily how to use the getter.

@hamishwillee hamishwillee requested a review from a team as a code owner May 10, 2021 04:07
@hamishwillee hamishwillee requested review from jpmedley, chrisdavidmills and wbamberg and removed request for a team and jpmedley May 10, 2021 04:07
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/AudioWorkletProcessor/parameterDescriptors
Title: AudioWorkletProcessor.parameterDescriptors (static getter)
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.AudioWorkletProcessor.parameterDescriptors

URL: /en-US/docs/Web/API/AudioParamDescriptor
Title: AudioParamDescriptor
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.AudioParamDescriptor

External URLs

URL: /en-US/docs/Web/API/AudioWorkletProcessor/parameterDescriptors
Title: AudioWorkletProcessor.parameterDescriptors (static getter)
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AudioParamDescriptor
Title: AudioParamDescriptor
on GitHub

No new external URLs

(this comment was updated 2021-05-10 04:15:58.499036)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good. Thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit 40353b0 into mdn:main May 10, 2021
@hamishwillee hamishwillee deleted the pagemacro_audioparamdesc branch May 11, 2021 02:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants